Title: [282644] releases/WebKitGTK/webkit-2.34/Source/WebKit
Revision
282644
Author
[email protected]
Date
2021-09-17 01:41:56 -0700 (Fri, 17 Sep 2021)

Log Message

Merge r282490 - [GTK][WPE] test animations/steps-transform-rendering-updates.html fails
https://bugs.webkit.org/show_bug.cgi?id=230307

Patch by Carlos Garcia Campos <[email protected]> on 2021-09-16
Reviewed by Carlos Alberto Lopez Perez.

ThreadedDisplayRefreshMonitor is not setting isScheduled back to false when it's fired. That causes
hasBeenRescheduled to be true and handleDisplayRefreshMonitorUpdate() is called with force repaint option, so we
end up flushing layers on every display refresh update.

* Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:
(WebKit::ThreadedDisplayRefreshMonitor::displayRefreshCallback):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog (282643 => 282644)


--- releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog	2021-09-17 08:41:11 UTC (rev 282643)
+++ releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog	2021-09-17 08:41:56 UTC (rev 282644)
@@ -1,3 +1,17 @@
+2021-09-16  Carlos Garcia Campos  <[email protected]>
+
+        [GTK][WPE] test animations/steps-transform-rendering-updates.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=230307
+
+        Reviewed by Carlos Alberto Lopez Perez.
+
+        ThreadedDisplayRefreshMonitor is not setting isScheduled back to false when it's fired. That causes
+        hasBeenRescheduled to be true and handleDisplayRefreshMonitorUpdate() is called with force repaint option, so we
+        end up flushing layers on every display refresh update.
+
+        * Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:
+        (WebKit::ThreadedDisplayRefreshMonitor::displayRefreshCallback):
+
 2021-09-14  Carlos Garcia Campos  <[email protected]>
 
         REGRESSION(r274929): [CoordinatedGraphics] DrawingAreaCoordinatedGraphics::createDisplayRefreshMonitor is no longer used

Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp (282643 => 282644)


--- releases/WebKitGTK/webkit-2.34/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp	2021-09-17 08:41:11 UTC (rev 282643)
+++ releases/WebKitGTK/webkit-2.34/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp	2021-09-17 08:41:56 UTC (rev 282644)
@@ -108,8 +108,10 @@
     {
         Locker locker { lock() };
         shouldHandleDisplayRefreshNotification = isScheduled() && isPreviousFrameDone();
-        if (shouldHandleDisplayRefreshNotification)
+        if (shouldHandleDisplayRefreshNotification) {
+            setIsScheduled(false);
             setIsPreviousFrameDone(false);
+        }
     }
 
     if (shouldHandleDisplayRefreshNotification) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to