Title: [284133] trunk/Tools
Revision
284133
Author
[email protected]
Date
2021-10-13 16:00:29 -0700 (Wed, 13 Oct 2021)

Log Message

Disable failing API tests
https://bugs.webkit.org/show_bug.cgi?id=231700

Unreviewed test gardening.

* TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
* TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
* TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
* TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
* TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
* TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDoesNotLogDuringInitialization.mm:
* TestWebKitAPI/Tests/ios/WKWebViewPausePlayingAudioTests.mm:

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (284132 => 284133)


--- trunk/Tools/ChangeLog	2021-10-13 22:52:48 UTC (rev 284132)
+++ trunk/Tools/ChangeLog	2021-10-13 23:00:29 UTC (rev 284133)
@@ -1,3 +1,18 @@
+2021-10-13  Ryan Haddad  <[email protected]>
+
+        Disable failing API tests
+        https://bugs.webkit.org/show_bug.cgi?id=231700
+
+        Unreviewed test gardening.
+
+        * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
+        * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
+        * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
+        * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
+        * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
+        * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDoesNotLogDuringInitialization.mm:
+        * TestWebKitAPI/Tests/ios/WKWebViewPausePlayingAudioTests.mm:
+
 2021-10-13  Jonathan Bedard  <[email protected]>
 
         [webkitscmpy] List reviewers for pull-request

Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm (284132 => 284133)


--- trunk/Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm	2021-10-13 22:52:48 UTC (rev 284132)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm	2021-10-13 23:00:29 UTC (rev 284133)
@@ -66,6 +66,8 @@
     return WTF::URLWithData(literalAsData(literal), nil);
 }
 
+// FIXME: Re-enable this test once webkit.org/b/231454 is resolved.
+#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 120000) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED < 150000)
 TEST(WTF_URLExtras, URLExtras)
 {
     EXPECT_STREQ("http://site.com", originalDataAsString(literalURL("http://site.com")));
@@ -81,6 +83,7 @@
     EXPECT_STREQ(".example.com", [WTF::decodeHostName(@"xn--.example.com") UTF8String]);
     EXPECT_STREQ("a..example.com", [WTF::decodeHostName(@"a..example.com") UTF8String]);
 }
+#endif
     
 TEST(WTF_URLExtras, URLExtras_Spoof)
 {

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm (284132 => 284133)


--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm	2021-10-13 22:52:48 UTC (rev 284132)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm	2021-10-13 23:00:29 UTC (rev 284133)
@@ -602,6 +602,8 @@
 
 namespace TestWebKitAPI {
 
+// FIXME: Re-enable these tests once webkit.org/b/231320 is resolved.
+#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 120000) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED < 150000)
 TEST(WebKit, ServerTrust)
 {
     HTTPServer server(HTTPServer::respondWithOK, HTTPServer::Protocol::Https);
@@ -631,6 +633,7 @@
     [delegate waitForDidFinishNavigation];
     EXPECT_EQ([delegate authenticationChallengeCount], 1ull);
 }
+#endif // (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 120000) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED < 150000)
 
 TEST(WebKit, ErrorSecureCoding)
 {

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm (284132 => 284133)


--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm	2021-10-13 22:52:48 UTC (rev 284132)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm	2021-10-13 23:00:29 UTC (rev 284133)
@@ -75,6 +75,8 @@
 
 namespace TestWebKitAPI {
 
+// FIXME: Re-enable this test once webkit.org/b/231396 is resolved.
+#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED < 150000
 TEST(WebKit, HTTPSProxy)
 {
     HTTPServer server(HTTPServer::respondWithOK, HTTPServer::Protocol::HttpsProxy);
@@ -92,6 +94,7 @@
     [webView loadRequest:[NSURLRequest requestWithURL:[NSURL URLWithString:@"https://example.com/"]]];
     EXPECT_WK_STREQ([delegate waitForAlert], "success!");
 }
+#endif
 
 TEST(WebKit, SOCKS5)
 {

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm (284132 => 284133)


--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm	2021-10-13 22:52:48 UTC (rev 284132)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm	2021-10-13 23:00:29 UTC (rev 284133)
@@ -520,6 +520,8 @@
     }).get());
 }
 
+// FIXME: Re-enable this test once webkit.org/b/231366 is resolved.
+#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED < 150000
 TEST(ResourceLoadStatistics, DataTaskIdentifierCollision)
 {
     using namespace TestWebKitAPI;
@@ -588,6 +590,7 @@
     EXPECT_TRUE(contains(messages, "1"));
     EXPECT_TRUE(contains(messages, "2"));
 }
+#endif
 
 TEST(ResourceLoadStatistics, NoMessagesWhenNotTesting)
 {

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm (284132 => 284133)


--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm	2021-10-13 22:52:48 UTC (rev 284132)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm	2021-10-13 23:00:29 UTC (rev 284133)
@@ -1571,6 +1571,8 @@
     EXPECT_WK_STREQ(@"Document URL: redirectone://bar.com/anothertest.html", [lastScriptMessage body]);
 }
 
+// FIXME: Re-enable this test once webkit.org/b/231394 is resolved.
+#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 120000) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED < 150000)
 TEST(URLSchemeHandler, Ranges)
 {
     RetainPtr<NSData> videoData = [NSData dataWithContentsOfURL:[[NSBundle mainBundle] URLForResource:@"test" withExtension:@"mp4" subdirectory:@"TestWebKitAPI.resources"]];
@@ -1620,6 +1622,7 @@
     EXPECT_WK_STREQ([webView _test_waitForAlert], "playing");
     EXPECT_TRUE(foundRangeRequest);
 }
+#endif
 
 TEST(URLSchemeHandler, HandleURLRewrittenByPlugIn)
 {

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDoesNotLogDuringInitialization.mm (284132 => 284133)


--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDoesNotLogDuringInitialization.mm	2021-10-13 22:52:48 UTC (rev 284132)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDoesNotLogDuringInitialization.mm	2021-10-13 23:00:29 UTC (rev 284133)
@@ -33,6 +33,8 @@
 #import <fcntl.h>
 #import <wtf/RetainPtr.h>
 
+// FIXME: Re-enable this test once webkit.org/b/231459 is resolved.
+#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 120000) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED < 150000)
 TEST(WKWebView, InitializingWebViewWithEphemeralStorageDoesNotLog)
 {
     // Replace stderr with a nonblocking pipe that we can read from.
@@ -56,3 +58,4 @@
         FAIL();
     }
 }
+#endif

Modified: trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewPausePlayingAudioTests.mm (284132 => 284133)


--- trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewPausePlayingAudioTests.mm	2021-10-13 22:52:48 UTC (rev 284132)
+++ trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewPausePlayingAudioTests.mm	2021-10-13 23:00:29 UTC (rev 284133)
@@ -69,6 +69,8 @@
     Util::run(&isPlaying);
 }
 
+// FIXME: Re-enable this test once webkit.org/b/230321 is resolved.
+#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED < 150000
 TEST(WKWebViewPausePlayingAudioTests, OutOfWindow)
 {
     auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:NSMakeRect(0, 0, 100, 100) configuration:autoplayingConfiguration().get() addToWindow:YES]);
@@ -102,6 +104,7 @@
 
     Util::run(&isPlaying);
 }
+#endif
 
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to