Title: [284134] trunk/Source/_javascript_Core
- Revision
- 284134
- Author
- [email protected]
- Date
- 2021-10-13 16:04:57 -0700 (Wed, 13 Oct 2021)
Log Message
[JSC] Update adjusted thread numbers
https://bugs.webkit.org/show_bug.cgi?id=231696
Reviewed by Saam Barati.
This adjusted numbers were empirically obtained at that time.
But after that, we switched bmalloc to libpas in ARM64 macOS
so that we removed scalability bottleneck in concurrent compilers.
We evaluated and adjusted the configuration again.
It improves Speedometer2 by 0.9% and JetStream2 by 0.7%.
----------------------------------------------------------------------------------------------------------------------------------
| subtest | ms | ms | b / a | pValue (significance using False Discovery Rate) |
----------------------------------------------------------------------------------------------------------------------------------
| Elm-TodoMVC |116.361667 |115.145000 |0.989544 | 0.000869 (significant) |
| VueJS-TodoMVC |23.195000 |22.483333 |0.969318 | 0.002243 (significant) |
| EmberJS-TodoMVC |124.720000 |121.211667 |0.971870 | 0.000000 (significant) |
| BackboneJS-TodoMVC |43.923333 |43.771667 |0.996547 | 0.338425 |
| Preact-TodoMVC |16.791667 |17.013333 |1.013201 | 0.337214 |
| AngularJS-TodoMVC |129.860000 |128.475000 |0.989335 | 0.000838 (significant) |
| Vanilla-ES2015-TodoMVC |61.703333 |61.625000 |0.998730 | 0.534118 |
| Inferno-TodoMVC |62.638333 |62.101667 |0.991432 | 0.045766 |
| Flight-TodoMVC |63.878333 |63.723333 |0.997574 | 0.578999 |
| Angular2-TypeScript-TodoMVC |41.601667 |40.015000 |0.961861 | 0.000070 (significant) |
| VanillaJS-TodoMVC |51.065000 |50.830000 |0.995398 | 0.284824 |
| jQuery-TodoMVC |213.223333 |212.976667 |0.998843 | 0.536898 |
| EmberJS-Debug-TodoMVC |333.051667 |331.588333 |0.995606 | 0.032867 |
| React-TodoMVC |82.665000 |82.540000 |0.998488 | 0.542365 |
| React-Redux-TodoMVC |134.823333 |133.665000 |0.991409 | 0.000002 (significant) |
| Vanilla-ES2015-Babel-Webpack-TodoMVC |59.983333 |59.941667 |0.999305 | 0.700077 |
----------------------------------------------------------------------------------------------------------------------------------
a mean = 271.53654
b mean = 274.08757
pValue = 0.0000000000
(Bigger means are better.)
1.009 times better
Results ARE significant
-------------------------------------------------------------------------------------------------------------------------
| subtest | pts | pts | b / a | pValue (significance using False Discovery Rate) |
-------------------------------------------------------------------------------------------------------------------------
| gaussian-blur |545.633826 |544.387097 |0.997715 | 0.632889 |
| HashSet-wasm |47.725969 |53.977426 |1.130986 | 0.014208 |
| gcc-loops-wasm |46.592278 |45.484195 |0.976217 | 0.188166 |
| json-parse-inspector |252.822356 |254.060654 |1.004898 | 0.261381 |
| prepack-wtb |60.534710 |60.580410 |1.000755 | 0.932640 |
| date-format-xparb-SP |445.456679 |450.988456 |1.012418 | 0.563115 |
| WSL |1.814989 |1.806757 |0.995464 | 0.035202 |
| OfflineAssembler |191.018184 |191.527453 |1.002666 | 0.512619 |
| cdjs |194.872003 |197.611972 |1.014060 | 0.006522 |
| UniPoker |522.254384 |520.751124 |0.997122 | 0.738800 |
| json-stringify-inspector |272.090046 |269.563607 |0.990715 | 0.156680 |
| crypto-sha1-SP |788.203441 |786.796976 |0.998216 | 0.889433 |
| Basic |705.357988 |704.506995 |0.998794 | 0.851524 |
| chai-wtb |108.246674 |109.283047 |1.009574 | 0.313095 |
| crypto-aes-SP |716.467647 |722.010176 |1.007736 | 0.589988 |
| Babylon |669.393771 |670.186691 |1.001185 | 0.908244 |
| string-unpack-code-SP |400.848798 |397.690936 |0.992122 | 0.379538 |
| stanford-crypto-aes |448.517790 |450.916593 |1.005348 | 0.421547 |
| raytrace |834.526654 |876.061864 |1.049771 | 0.000000 (significant) |
| multi-inspector-code-load |398.195009 |400.638554 |1.006137 | 0.624663 |
| hash-map |588.390020 |593.336508 |1.008407 | 0.032313 |
| stanford-crypto-pbkdf2 |705.031717 |714.947310 |1.014064 | 0.451490 |
| coffeescript-wtb |41.104563 |41.590079 |1.011812 | 0.104485 |
| Box2D |457.517551 |457.676651 |1.000348 | 0.938025 |
| lebab-wtb |63.284589 |63.746412 |1.007298 | 0.021550 |
| tsf-wasm |121.000104 |116.584889 |0.963511 | 0.566993 |
| base64-SP |627.310289 |631.360337 |1.006456 | 0.380323 |
| navier-stokes |717.211598 |715.546883 |0.997679 | 0.776740 |
| jshint-wtb |52.822264 |53.067727 |1.004647 | 0.265734 |
| regex-dna-SP |444.626036 |444.565652 |0.999864 | 0.981250 |
| async-fs |232.138408 |234.088380 |1.008400 | 0.084059 |
| crypto-md5-SP |738.555352 |739.048809 |1.000668 | 0.936794 |
| first-inspector-code-load |272.911902 |274.186589 |1.004671 | 0.223172 |
| segmentation |53.421830 |53.253527 |0.996850 | 0.488595 |
| typescript |26.619459 |26.404921 |0.991941 | 0.021613 |
| octane-code-load |1229.345392 |1238.504125 |1.007450 | 0.273224 |
| float-mm.c |17.443005 |17.474949 |1.001831 | 0.160549 |
| quicksort-wasm |472.609429 |490.175315 |1.037168 | 0.134603 |
| Air |420.285523 |422.507814 |1.005288 | 0.535574 |
| splay |472.850630 |484.805521 |1.025283 | 0.202943 |
| ai-astar |663.547782 |684.429114 |1.031469 | 0.035910 |
| acorn-wtb |68.978436 |69.675311 |1.010103 | 0.085505 |
| gbemu |159.998563 |154.256612 |0.964112 | 0.052665 |
| richards |957.006036 |970.082604 |1.013664 | 0.080437 |
| 3d-cube-SP |539.329388 |548.346324 |1.016719 | 0.126931 |
| espree-wtb |71.026174 |72.950691 |1.027096 | 0.005430 |
| bomb-workers |100.837095 |102.616328 |1.017645 | 0.024650 |
| tagcloud-SP |293.735729 |295.721652 |1.006761 | 0.604433 |
| mandreel |150.843346 |151.169263 |1.002161 | 0.406810 |
| 3d-raytrace-SP |503.282797 |508.519569 |1.010405 | 0.330728 |
| delta-blue |1064.779647 |1085.099791 |1.019084 | 0.111789 |
| ML |143.453624 |144.404535 |1.006629 | 0.054459 |
| regexp |465.598651 |469.139986 |1.007606 | 0.040131 |
| crypto |1534.715604 |1518.978823 |0.989746 | 0.398916 |
| richards-wasm |144.325337 |144.296964 |0.999803 | 0.993066 |
| earley-boyer |831.216095 |862.902139 |1.038120 | 0.089284 |
| octane-zlib |27.146237 |27.203847 |1.002122 | 0.668749 |
| date-format-tofte-SP |390.913746 |391.453527 |1.001381 | 0.837893 |
| n-body-SP |1142.063928 |1139.347984 |0.997622 | 0.764020 |
| pdfjs |183.711632 |185.851180 |1.011646 | 0.144519 |
| FlightPlanner |908.621057 |901.866743 |0.992566 | 0.434806 |
| uglify-js-wtb |34.644842 |34.797497 |1.004406 | 0.126209 |
| babylon-wtb |82.702004 |83.505631 |1.009717 | 0.092402 |
| stanford-crypto-sha256 |810.898597 |810.480366 |0.999484 | 0.943677 |
-------------------------------------------------------------------------------------------------------------------------
a mean = 242.30806
b mean = 243.91901
pValue = 0.0014473755
(Bigger means are better.)
1.007 times better
Results ARE significant
* runtime/Options.cpp:
(JSC::overrideDefaults):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (284133 => 284134)
--- trunk/Source/_javascript_Core/ChangeLog 2021-10-13 23:00:29 UTC (rev 284133)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-10-13 23:04:57 UTC (rev 284134)
@@ -1,3 +1,123 @@
+2021-10-13 Yusuke Suzuki <[email protected]>
+
+ [JSC] Update adjusted thread numbers
+ https://bugs.webkit.org/show_bug.cgi?id=231696
+
+ Reviewed by Saam Barati.
+
+ This adjusted numbers were empirically obtained at that time.
+ But after that, we switched bmalloc to libpas in ARM64 macOS
+ so that we removed scalability bottleneck in concurrent compilers.
+
+ We evaluated and adjusted the configuration again.
+
+ It improves Speedometer2 by 0.9% and JetStream2 by 0.7%.
+
+ ----------------------------------------------------------------------------------------------------------------------------------
+ | subtest | ms | ms | b / a | pValue (significance using False Discovery Rate) |
+ ----------------------------------------------------------------------------------------------------------------------------------
+ | Elm-TodoMVC |116.361667 |115.145000 |0.989544 | 0.000869 (significant) |
+ | VueJS-TodoMVC |23.195000 |22.483333 |0.969318 | 0.002243 (significant) |
+ | EmberJS-TodoMVC |124.720000 |121.211667 |0.971870 | 0.000000 (significant) |
+ | BackboneJS-TodoMVC |43.923333 |43.771667 |0.996547 | 0.338425 |
+ | Preact-TodoMVC |16.791667 |17.013333 |1.013201 | 0.337214 |
+ | AngularJS-TodoMVC |129.860000 |128.475000 |0.989335 | 0.000838 (significant) |
+ | Vanilla-ES2015-TodoMVC |61.703333 |61.625000 |0.998730 | 0.534118 |
+ | Inferno-TodoMVC |62.638333 |62.101667 |0.991432 | 0.045766 |
+ | Flight-TodoMVC |63.878333 |63.723333 |0.997574 | 0.578999 |
+ | Angular2-TypeScript-TodoMVC |41.601667 |40.015000 |0.961861 | 0.000070 (significant) |
+ | VanillaJS-TodoMVC |51.065000 |50.830000 |0.995398 | 0.284824 |
+ | jQuery-TodoMVC |213.223333 |212.976667 |0.998843 | 0.536898 |
+ | EmberJS-Debug-TodoMVC |333.051667 |331.588333 |0.995606 | 0.032867 |
+ | React-TodoMVC |82.665000 |82.540000 |0.998488 | 0.542365 |
+ | React-Redux-TodoMVC |134.823333 |133.665000 |0.991409 | 0.000002 (significant) |
+ | Vanilla-ES2015-Babel-Webpack-TodoMVC |59.983333 |59.941667 |0.999305 | 0.700077 |
+ ----------------------------------------------------------------------------------------------------------------------------------
+ a mean = 271.53654
+ b mean = 274.08757
+ pValue = 0.0000000000
+ (Bigger means are better.)
+ 1.009 times better
+ Results ARE significant
+
+ -------------------------------------------------------------------------------------------------------------------------
+ | subtest | pts | pts | b / a | pValue (significance using False Discovery Rate) |
+ -------------------------------------------------------------------------------------------------------------------------
+ | gaussian-blur |545.633826 |544.387097 |0.997715 | 0.632889 |
+ | HashSet-wasm |47.725969 |53.977426 |1.130986 | 0.014208 |
+ | gcc-loops-wasm |46.592278 |45.484195 |0.976217 | 0.188166 |
+ | json-parse-inspector |252.822356 |254.060654 |1.004898 | 0.261381 |
+ | prepack-wtb |60.534710 |60.580410 |1.000755 | 0.932640 |
+ | date-format-xparb-SP |445.456679 |450.988456 |1.012418 | 0.563115 |
+ | WSL |1.814989 |1.806757 |0.995464 | 0.035202 |
+ | OfflineAssembler |191.018184 |191.527453 |1.002666 | 0.512619 |
+ | cdjs |194.872003 |197.611972 |1.014060 | 0.006522 |
+ | UniPoker |522.254384 |520.751124 |0.997122 | 0.738800 |
+ | json-stringify-inspector |272.090046 |269.563607 |0.990715 | 0.156680 |
+ | crypto-sha1-SP |788.203441 |786.796976 |0.998216 | 0.889433 |
+ | Basic |705.357988 |704.506995 |0.998794 | 0.851524 |
+ | chai-wtb |108.246674 |109.283047 |1.009574 | 0.313095 |
+ | crypto-aes-SP |716.467647 |722.010176 |1.007736 | 0.589988 |
+ | Babylon |669.393771 |670.186691 |1.001185 | 0.908244 |
+ | string-unpack-code-SP |400.848798 |397.690936 |0.992122 | 0.379538 |
+ | stanford-crypto-aes |448.517790 |450.916593 |1.005348 | 0.421547 |
+ | raytrace |834.526654 |876.061864 |1.049771 | 0.000000 (significant) |
+ | multi-inspector-code-load |398.195009 |400.638554 |1.006137 | 0.624663 |
+ | hash-map |588.390020 |593.336508 |1.008407 | 0.032313 |
+ | stanford-crypto-pbkdf2 |705.031717 |714.947310 |1.014064 | 0.451490 |
+ | coffeescript-wtb |41.104563 |41.590079 |1.011812 | 0.104485 |
+ | Box2D |457.517551 |457.676651 |1.000348 | 0.938025 |
+ | lebab-wtb |63.284589 |63.746412 |1.007298 | 0.021550 |
+ | tsf-wasm |121.000104 |116.584889 |0.963511 | 0.566993 |
+ | base64-SP |627.310289 |631.360337 |1.006456 | 0.380323 |
+ | navier-stokes |717.211598 |715.546883 |0.997679 | 0.776740 |
+ | jshint-wtb |52.822264 |53.067727 |1.004647 | 0.265734 |
+ | regex-dna-SP |444.626036 |444.565652 |0.999864 | 0.981250 |
+ | async-fs |232.138408 |234.088380 |1.008400 | 0.084059 |
+ | crypto-md5-SP |738.555352 |739.048809 |1.000668 | 0.936794 |
+ | first-inspector-code-load |272.911902 |274.186589 |1.004671 | 0.223172 |
+ | segmentation |53.421830 |53.253527 |0.996850 | 0.488595 |
+ | typescript |26.619459 |26.404921 |0.991941 | 0.021613 |
+ | octane-code-load |1229.345392 |1238.504125 |1.007450 | 0.273224 |
+ | float-mm.c |17.443005 |17.474949 |1.001831 | 0.160549 |
+ | quicksort-wasm |472.609429 |490.175315 |1.037168 | 0.134603 |
+ | Air |420.285523 |422.507814 |1.005288 | 0.535574 |
+ | splay |472.850630 |484.805521 |1.025283 | 0.202943 |
+ | ai-astar |663.547782 |684.429114 |1.031469 | 0.035910 |
+ | acorn-wtb |68.978436 |69.675311 |1.010103 | 0.085505 |
+ | gbemu |159.998563 |154.256612 |0.964112 | 0.052665 |
+ | richards |957.006036 |970.082604 |1.013664 | 0.080437 |
+ | 3d-cube-SP |539.329388 |548.346324 |1.016719 | 0.126931 |
+ | espree-wtb |71.026174 |72.950691 |1.027096 | 0.005430 |
+ | bomb-workers |100.837095 |102.616328 |1.017645 | 0.024650 |
+ | tagcloud-SP |293.735729 |295.721652 |1.006761 | 0.604433 |
+ | mandreel |150.843346 |151.169263 |1.002161 | 0.406810 |
+ | 3d-raytrace-SP |503.282797 |508.519569 |1.010405 | 0.330728 |
+ | delta-blue |1064.779647 |1085.099791 |1.019084 | 0.111789 |
+ | ML |143.453624 |144.404535 |1.006629 | 0.054459 |
+ | regexp |465.598651 |469.139986 |1.007606 | 0.040131 |
+ | crypto |1534.715604 |1518.978823 |0.989746 | 0.398916 |
+ | richards-wasm |144.325337 |144.296964 |0.999803 | 0.993066 |
+ | earley-boyer |831.216095 |862.902139 |1.038120 | 0.089284 |
+ | octane-zlib |27.146237 |27.203847 |1.002122 | 0.668749 |
+ | date-format-tofte-SP |390.913746 |391.453527 |1.001381 | 0.837893 |
+ | n-body-SP |1142.063928 |1139.347984 |0.997622 | 0.764020 |
+ | pdfjs |183.711632 |185.851180 |1.011646 | 0.144519 |
+ | FlightPlanner |908.621057 |901.866743 |0.992566 | 0.434806 |
+ | uglify-js-wtb |34.644842 |34.797497 |1.004406 | 0.126209 |
+ | babylon-wtb |82.702004 |83.505631 |1.009717 | 0.092402 |
+ | stanford-crypto-sha256 |810.898597 |810.480366 |0.999484 | 0.943677 |
+ -------------------------------------------------------------------------------------------------------------------------
+ a mean = 242.30806
+ b mean = 243.91901
+ pValue = 0.0014473755
+ (Bigger means are better.)
+ 1.007 times better
+ Results ARE significant
+
+ * runtime/Options.cpp:
+ (JSC::overrideDefaults):
+
2021-10-13 Mikhail R. Gadelha <[email protected]>
[JSC][32bit] Fix wrong branchAdd32 assembly for ARMv7
Modified: trunk/Source/_javascript_Core/runtime/Options.cpp (284133 => 284134)
--- trunk/Source/_javascript_Core/runtime/Options.cpp 2021-10-13 23:00:29 UTC (rev 284133)
+++ trunk/Source/_javascript_Core/runtime/Options.cpp 2021-10-13 23:04:57 UTC (rev 284134)
@@ -354,8 +354,8 @@
#if PLATFORM(MAC) && CPU(ARM64)
Options::numberOfGCMarkers() = 4;
- Options::numberOfDFGCompilerThreads() = 2;
- Options::numberOfFTLCompilerThreads() = 2;
+ Options::numberOfDFGCompilerThreads() = 3;
+ Options::numberOfFTLCompilerThreads() = 3;
#endif
#if USE(BMALLOC_MEMORY_FOOTPRINT_API)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
