Title: [284846] trunk/Tools
- Revision
- 284846
- Author
- [email protected]
- Date
- 2021-10-25 16:33:05 -0700 (Mon, 25 Oct 2021)
Log Message
Clean up App Bound Domains tests
https://bugs.webkit.org/show_bug.cgi?id=232278
Reviewed by John Wilander.
* TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
(TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (284845 => 284846)
--- trunk/Tools/ChangeLog 2021-10-25 23:25:03 UTC (rev 284845)
+++ trunk/Tools/ChangeLog 2021-10-25 23:33:05 UTC (rev 284846)
@@ -1,3 +1,13 @@
+2021-10-25 Kate Cheney <[email protected]>
+
+ Clean up App Bound Domains tests
+ https://bugs.webkit.org/show_bug.cgi?id=232278
+
+ Reviewed by John Wilander.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
+ (TEST):
+
2021-10-25 Simon Fraser <[email protected]>
webkitpy: Add an explicit ImageDiffResult.passed rather than relying on diff_image being non-None
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm (284845 => 284846)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm 2021-10-25 23:25:03 UTC (rev 284845)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm 2021-10-25 23:33:05 UTC (rev 284846)
@@ -677,6 +677,7 @@
TestWebKitAPI::Util::run(&gotFlag);
[globalCookieStore removeObserver:observer.get()];
+ cleanUpInAppBrowserPrivacyTestSettings();
}
TEST(InAppBrowserPrivacy, GetCookieForNonAppBoundDomainFails)
@@ -1164,6 +1165,7 @@
}];
TestWebKitAPI::Util::run(&isDone);
+ cleanUpInAppBrowserPrivacyTestSettings();
}
TEST(InAppBrowserPrivacy, WebViewCannotUpdateAppBoundFlagOnceSet)
@@ -1231,6 +1233,7 @@
[webView loadRequest:request];
NSError *error = [delegate waitForDidFailProvisionalNavigationError];
EXPECT_EQ(error.code, WKErrorNavigationAppBoundDomain);
+ cleanUpInAppBrowserPrivacyTestSettings();
}
TEST(InAppBrowserPrivacy, InjectScriptInNonAppBoundSubframeAppBoundMainframeFails)
@@ -1340,6 +1343,7 @@
}
TestWebKitAPI::Util::run(&isDone);
+ cleanUpInAppBrowserPrivacyTestSettings();
}
TEST(InAppBrowserPrivacy, LoadFromHTMLStringsSucceedsIfAppBound)
@@ -1485,6 +1489,7 @@
NSURLRequest *request = [NSURLRequest requestWithURL:[NSURL URLWithString:url]];
[webView loadRequest:request];
TestWebKitAPI::Util::run(&didFinishNavigation);
+ cleanUpInAppBrowserPrivacyTestSettings();
}
TEST(InAppBrowserPrivacy, AboutBlankSubFrameMatchesTopFrameAppBound)
@@ -1523,6 +1528,7 @@
}];
}
TestWebKitAPI::Util::run(&isDone);
+ cleanUpInAppBrowserPrivacyTestSettings();
}
TEST(InAppBrowserPrivacy, AboutBlankSubFrameMatchesTopFrameNonAppBound)
@@ -1551,6 +1557,7 @@
}];
}
TestWebKitAPI::Util::run(&isDone);
+ cleanUpInAppBrowserPrivacyTestSettings();
}
#endif // ENABLE(APP_BOUND_DOMAINS)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
