Title: [284848] trunk
- Revision
- 284848
- Author
- [email protected]
- Date
- 2021-10-25 16:39:50 -0700 (Mon, 25 Oct 2021)
Log Message
Remove assert failure expectations after r284846 landed
https://bugs.webkit.org/show_bug.cgi?id=232048
<rdar://problem/84479642>
https://bugs.webkit.org/show_bug.cgi?id=232102
<rdar://problem/84521189>
https://bugs.webkit.org/show_bug.cgi?id=231255
<rdar://problem/83903881>
https://bugs.webkit.org/show_bug.cgi?id=231431
<rdar://problem/84029425>
Unreviewed test gardening.
Depends on this fix: https://trac.webkit.org/changeset/284846/webkit
Source/WebKit:
* NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::setPrivateClickMeasurementAppBundleIDForTesting):
Removed comment with Bugzilla reference.
I decided to keep the logging since it was so useful in finding the root
cause of the assertion crashes. Logging is only triggered when we will
fail the assertion.
LayoutTests:
* platform/ios-wk2/TestExpectations:
Removed crash expectations now that the app bundle ID setting for InAppBrowserPrivacy
API tests is being cleared after each test.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (284847 => 284848)
--- trunk/LayoutTests/ChangeLog 2021-10-25 23:33:27 UTC (rev 284847)
+++ trunk/LayoutTests/ChangeLog 2021-10-25 23:39:50 UTC (rev 284848)
@@ -1,3 +1,23 @@
+2021-10-25 John Wilander <[email protected]>
+
+ Remove assert failure expectations after r284846 landed
+ https://bugs.webkit.org/show_bug.cgi?id=232048
+ <rdar://problem/84479642>
+ https://bugs.webkit.org/show_bug.cgi?id=232102
+ <rdar://problem/84521189>
+ https://bugs.webkit.org/show_bug.cgi?id=231255
+ <rdar://problem/83903881>
+ https://bugs.webkit.org/show_bug.cgi?id=231431
+ <rdar://problem/84029425>
+
+ Unreviewed test gardening.
+
+ Depends on this fix: https://trac.webkit.org/changeset/284846/webkit
+
+ * platform/ios-wk2/TestExpectations:
+ Removed crash expectations now that the app bundle ID setting for InAppBrowserPrivacy
+ API tests is being cleared after each test.
+
2021-10-25 Eric Hutchison <[email protected]>
[ Mac wk1 ] 2 media-capabilities/webrtc tests are flaky failures.
Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (284847 => 284848)
--- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-25 23:33:27 UTC (rev 284847)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-25 23:39:50 UTC (rev 284848)
@@ -2150,12 +2150,6 @@
webkit.org/b/222563 [ Release ] http/tests/loading/basic-auth-load-URL-with-consecutive-slashes.html [ Pass Failure ]
-webkit.org/b/231255 http/tests/privateClickMeasurement/attribution-conversion-through-cross-site-image-redirect.html [ Pass Crash ]
-
-webkit.org/b/231431 http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive.html [ Pass Crash ]
-
-webkit.org/b/231748 http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-ephemeral.html [ Pass Crash ]
-
webkit.org/b/229563 imported/w3c/web-platform-tests/css/css-display/display-contents-blockify-dynamic.html [ Pass Timeout ]
webkit.org/b/229567 [ Release ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-subpixel-clip.html [ Pass ImageOnlyFailure ]
@@ -2228,8 +2222,6 @@
webkit.org/b/232099 imported/w3c/web-platform-tests/websockets/Close-1000.any.html [ Pass Crash ]
-webkit.org/b/232102 http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority.html [ Pass Crash ]
-
webkit.org/b/232120 imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-multiple-policies-multiple-hashing-algorithms.html [ Pass Failure DumpJSConsoleLogInStdErr ]
webkit.org/b/225528 http/wpt/fetch/fetch-response-body-stop-in-worker.html [ Pass Crash ]
Modified: trunk/Source/WebKit/ChangeLog (284847 => 284848)
--- trunk/Source/WebKit/ChangeLog 2021-10-25 23:33:27 UTC (rev 284847)
+++ trunk/Source/WebKit/ChangeLog 2021-10-25 23:39:50 UTC (rev 284848)
@@ -1,3 +1,26 @@
+2021-10-25 John Wilander <[email protected]>
+
+ Remove assert failure expectations after r284846 landed
+ https://bugs.webkit.org/show_bug.cgi?id=232048
+ <rdar://problem/84479642>
+ https://bugs.webkit.org/show_bug.cgi?id=232102
+ <rdar://problem/84521189>
+ https://bugs.webkit.org/show_bug.cgi?id=231255
+ <rdar://problem/83903881>
+ https://bugs.webkit.org/show_bug.cgi?id=231431
+ <rdar://problem/84029425>
+
+ Unreviewed test gardening.
+
+ Depends on this fix: https://trac.webkit.org/changeset/284846/webkit
+
+ * NetworkProcess/NetworkSession.cpp:
+ (WebKit::NetworkSession::setPrivateClickMeasurementAppBundleIDForTesting):
+ Removed comment with Bugzilla reference.
+ I decided to keep the logging since it was so useful in finding the root
+ cause of the assertion crashes. Logging is only triggered when we will
+ fail the assertion.
+
2021-10-25 Wenson Hsieh <[email protected]>
Rename a few variable and parameter names in WKContentViewInteraction.mm
Modified: trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp (284847 => 284848)
--- trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp 2021-10-25 23:33:27 UTC (rev 284847)
+++ trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp 2021-10-25 23:39:50 UTC (rev 284848)
@@ -455,7 +455,6 @@
void NetworkSession::setPrivateClickMeasurementAppBundleIDForTesting(String&& appBundleIDForTesting)
{
#if PLATFORM(COCOA)
- // FIXME: Remove this logging once https://bugs.webkit.org/show_bug.cgi?id=232048 has been resolved.
auto appBundleID = WebCore::applicationBundleIdentifier();
if (!isRunningTest(appBundleID))
WTFLogAlways("isRunningTest() returned false. appBundleID is %s.", appBundleID.isEmpty() ? "empty" : appBundleID.utf8().data());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
