Title: [107297] trunk/Tools
- Revision
- 107297
- Author
- [email protected]
- Date
- 2012-02-09 15:09:51 -0800 (Thu, 09 Feb 2012)
Log Message
Remove the cr-mac-ews (it's long been dead)
https://bugs.webkit.org/show_bug.cgi?id=78267
Reviewed by Adam Barth.
* QueueStatusServer/model/queues.py:
(Queue):
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(ChromiumWindowsEWS):
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSytemTest._test_builder_ews):
(EarlyWarningSytemTest._test_testing_ews):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (107296 => 107297)
--- trunk/Tools/ChangeLog 2012-02-09 23:09:38 UTC (rev 107296)
+++ trunk/Tools/ChangeLog 2012-02-09 23:09:51 UTC (rev 107297)
@@ -1,3 +1,18 @@
+2012-02-09 Eric Seidel <[email protected]>
+
+ Remove the cr-mac-ews (it's long been dead)
+ https://bugs.webkit.org/show_bug.cgi?id=78267
+
+ Reviewed by Adam Barth.
+
+ * QueueStatusServer/model/queues.py:
+ (Queue):
+ * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
+ (ChromiumWindowsEWS):
+ * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
+ (EarlyWarningSytemTest._test_builder_ews):
+ (EarlyWarningSytemTest._test_testing_ews):
+
2012-02-09 Dirk Pranke <[email protected]>
some tests in webkitpy are being run three times
Modified: trunk/Tools/QueueStatusServer/model/queues.py (107296 => 107297)
--- trunk/Tools/QueueStatusServer/model/queues.py 2012-02-09 23:09:38 UTC (rev 107296)
+++ trunk/Tools/QueueStatusServer/model/queues.py 2012-02-09 23:09:51 UTC (rev 107297)
@@ -39,13 +39,12 @@
_all_queue_names = [
"commit-queue",
"style-queue",
- "chromium-ews",
+ "chromium-ews", # aka cr-linux-ews
"qt-ews",
"gtk-ews",
"mac-ews",
"win-ews",
"efl-ews",
- "cr-mac-ews",
]
def __init__(self, name):
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py (107296 => 107297)
--- trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py 2012-02-09 23:09:38 UTC (rev 107296)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py 2012-02-09 23:09:51 UTC (rev 107297)
@@ -186,24 +186,6 @@
name = "cr-win-ews"
-# For platforms that we can't run inside a VM (like Mac OS X), we require
-# patches to be uploaded by committers, who are generally trustworthy folk. :)
-class AbstractCommitterOnlyEWS(AbstractEarlyWarningSystem):
- def process_work_item(self, patch):
- if not patch.attacher() or not patch.attacher().can_commit:
- self._did_error(patch, "%s cannot process patches from non-committers :(" % self.name)
- return False
- return AbstractEarlyWarningSystem.process_work_item(self, patch)
-
-
-# FIXME: Inheriting from AbstractCommitterOnlyEWS is kinda a hack, but it
-# happens to work because AbstractChromiumEWS and AbstractCommitterOnlyEWS
-# provide disjoint sets of functionality, and Python is otherwise smart
-# enough to handle the diamond inheritance.
-class ChromiumMacEWS(AbstractChromiumEWS, AbstractCommitterOnlyEWS):
- name = "cr-mac-ews"
-
-
class MacEWS(AbstractEarlyWarningSystem):
name = "mac-ews"
port_name = "mac"
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py (107296 => 107297)
--- trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py 2012-02-09 23:09:38 UTC (rev 107296)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py 2012-02-09 23:09:51 UTC (rev 107297)
@@ -71,13 +71,6 @@
ews.bind_to_tool(MockTool())
self.assert_queue_outputs(ews, expected_stderr=self._default_expected_stderr(ews))
- def _test_committer_only_ews(self, ews):
- ews.bind_to_tool(MockTool())
- expected_stderr = self._default_expected_stderr(ews)
- string_replacemnts = {"name": ews.name}
- expected_stderr["process_work_item"] = "MOCK: update_status: %(name)s Error: %(name)s cannot process patches from non-committers :(\nMOCK: release_work_item: %(name)s 10000\n" % string_replacemnts
- self.assert_queue_outputs(ews, expected_stderr=expected_stderr)
-
def _test_testing_ews(self, ews):
ews.layout_test_results = lambda: None
ews.bind_to_tool(MockTool())
@@ -85,9 +78,6 @@
expected_stderr["handle_script_error"] = "ScriptError error message\n"
self.assert_queue_outputs(ews, expected_stderr=expected_stderr)
- def test_committer_only_ewses(self):
- self._test_committer_only_ews(ChromiumMacEWS())
-
def test_builder_ewses(self):
self._test_builder_ews(MacEWS())
self._test_builder_ews(ChromiumWindowsEWS())
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
