Title: [294461] trunk/Source/_javascript_Core/CMakeLists.txt
Revision
294461
Author
[email protected]
Date
2022-05-18 19:28:00 -0700 (Wed, 18 May 2022)

Log Message

_javascript_Core/DerivedSources/Bytecodes.h is generated twice both in Bytecodes.vcxproj in LLIntSettingsExtractor.vcxproj
https://bugs.webkit.org/show_bug.cgi?id=240556

Reviewed by Don Olmstead.

In CMake Visual Studio generator builds, Bytecodes.h was generated
twice both in Bytecodes.vcxproj in LLIntSettingsExtractor.vcxproj.

The fundamental problem of this bug was fixed in CMake v3.12.
<https://gitlab.kitware.com/cmake/cmake/-/commit/5a6c6292898fe238f3a5105133b8904209fbedaf>

LLIntSettingsExtractor target needs to have a direct or indirect
dependency to Bytecodes target for CMake Visual Studio generator to
eliminate duplicated custom commands.

* Source/_javascript_Core/CMakeLists.txt:

Canonical link: https://commits.webkit.org/250723@main

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/CMakeLists.txt (294460 => 294461)


--- trunk/Source/_javascript_Core/CMakeLists.txt	2022-05-19 02:12:19 UTC (rev 294460)
+++ trunk/Source/_javascript_Core/CMakeLists.txt	2022-05-19 02:28:00 UTC (rev 294461)
@@ -398,6 +398,12 @@
 set(LLIntSettingsExtractor_DEPENDENCIES _javascript_Core_CopyHeaders)
 WEBKIT_EXECUTABLE(LLIntSettingsExtractor)
 
+# LLIntSettingsExtractor target needs to have a direct or indirect
+# dependency to Bytecodes target for CMake Visual Studio generator to
+# eliminate duplicated custom commands. Otherwise, Bytecodes.h will be
+# generated in both projects.
+add_dependencies(LLIntSettingsExtractor Bytecodes)
+
 WEBKIT_EXECUTABLE_DECLARE(LLIntOffsetsExtractor)
 set(LLIntOffsetsExtractor_SOURCES
     ${_javascript_CORE_DIR}/llint/LLIntOffsetsExtractor.cpp
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to