Title: [294462] trunk/Source/_javascript_Core/CMakeLists.txt
Revision
294462
Author
[email protected]
Date
2022-05-18 19:29:12 -0700 (Wed, 18 May 2022)

Log Message

PrivateHeaders/_javascript_Core/InspectorProtocolObjects.h isn't regenerated in incremental builds
https://bugs.webkit.org/show_bug.cgi?id=240540

Reviewed by Don Olmstead.

In CMake Visual Studio generator builds, InspectorProtocolObjects.h
was not copied to the private headers directory as expected in
incremental builds.

${_javascript_Core_DERIVED_SOURCES_DIR}/inspector/InspectorProtocolObjects.h
was added to both _javascript_Core_PRIVATE_FRAMEWORK_HEADERS and
_javascript_Core_HEADERS. This caused the incremental build problem.
Don't add such headers to _javascript_Core_HEADERS.

* Source/_javascript_Core/CMakeLists.txt:

Canonical link: https://commits.webkit.org/250724@main

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/CMakeLists.txt (294461 => 294462)


--- trunk/Source/_javascript_Core/CMakeLists.txt	2022-05-19 02:28:00 UTC (rev 294461)
+++ trunk/Source/_javascript_Core/CMakeLists.txt	2022-05-19 02:29:12 UTC (rev 294462)
@@ -1405,13 +1405,6 @@
     VERBATIM)
 add_custom_target(InspectorBackendCommands DEPENDS "${_javascript_Core_DERIVED_SOURCES_DIR}/inspector/InspectorBackendCommands.js")
 
-list(APPEND _javascript_Core_HEADERS
-    ${_javascript_Core_DERIVED_SOURCES_DIR}/inspector/InspectorBackendDispatchers.h
-    ${_javascript_Core_DERIVED_SOURCES_DIR}/inspector/InspectorFrontendDispatchers.h
-    ${_javascript_Core_DERIVED_SOURCES_DIR}/inspector/InspectorProtocolObjects.h
-    ${_javascript_Core_DERIVED_SOURCES_DIR}/JSCBuiltins.h
-)
-
 if (WTF_CPU_X86_64)
     if (MSVC AND NOT ENABLE_C_LOOP)
         add_custom_command(
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to