Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d0a00be94060f009349aca4f348324686b799056
https://github.com/WebKit/WebKit/commit/d0a00be94060f009349aca4f348324686b799056
Author: Youenn Fablet <[email protected]>
Date: 2023-04-17 (Mon, 17 Apr 2023)
Changed paths:
A LayoutTests/fast/mediastream/camera-unknown-facing-mode-expected.txt
A LayoutTests/fast/mediastream/camera-unknown-facing-mode.html
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm
M Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp
M Source/WebKit/UIProcess/API/C/WKMockMediaDevice.cpp
M Source/WebKit/UIProcess/API/C/WKMockMediaDevice.h
M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
M Tools/WebKitTestRunner/TestController.cpp
M Tools/WebKitTestRunner/TestController.h
M Tools/WebKitTestRunner/TestInvocation.cpp
Log Message:
-----------
Do not take into account device orientation for cameras whose position is
unspecified
https://bugs.webkit.org/show_bug.cgi?id=255448
rdar://problem/108043783
Reviewed by Eric Carlson.
Skip orientation monitoring in case facing mode is unspecified, as this means
the sensor is not guaranteed to be attached to the device.
Update mock infrastructure accordingly and allow to add cameras with undefined
facing mode.
Covered by added test.
* LayoutTests/fast/mediastream/camera-unknown-facing-mode-expected.txt: Added.
* LayoutTests/fast/mediastream/camera-unknown-facing-mode.html: Added.
* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::monitorOrientation):
* Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::capabilities):
(WebCore::MockRealtimeVideoSource::settings):
(WebCore::MockRealtimeVideoSource::monitorOrientation):
* Source/WebKit/UIProcess/API/C/WKMockMediaDevice.cpp:
(WKAddMockMediaDevice):
* Source/WebKit/UIProcess/API/C/WKMockMediaDevice.h:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::addMockMediaDevice):
(WTR::TestRunner::addMockCameraDevice):
(WTR::TestRunner::addMockMicrophoneDevice):
(WTR::TestRunner::addMockScreenDevice):
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::addMockMediaDevice):
* Tools/WebKitTestRunner/TestController.h:
* Tools/WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
Canonical link: https://commits.webkit.org/263018@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
