Title: [109442] trunk/Source/WebCore
- Revision
- 109442
- Author
- [email protected]
- Date
- 2012-03-01 15:17:12 -0800 (Thu, 01 Mar 2012)
Log Message
[chromium] Partial texture updates not happening with accelerated painting path
https://bugs.webkit.org/show_bug.cgi?id=80040
Reviewed by James Robinson.
The order of y-flip and clip-rect was opposite of what it should be.
The clip rect was not properly transformed to account for y-flip and hence clipping everything.
* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (109441 => 109442)
--- trunk/Source/WebCore/ChangeLog 2012-03-01 23:16:54 UTC (rev 109441)
+++ trunk/Source/WebCore/ChangeLog 2012-03-01 23:17:12 UTC (rev 109442)
@@ -1,3 +1,16 @@
+2012-03-01 Alok Priyadarshi <[email protected]>
+
+ [chromium] Partial texture updates not happening with accelerated painting path
+ https://bugs.webkit.org/show_bug.cgi?id=80040
+
+ Reviewed by James Robinson.
+
+ The order of y-flip and clip-rect was opposite of what it should be.
+ The clip rect was not properly transformed to account for y-flip and hence clipping everything.
+
+ * platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
+ (WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):
+
2012-03-01 Alexey Proskuryakov <[email protected]>
FileReader read speed is way too low
Modified: trunk/Source/WebCore/platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp (109441 => 109442)
--- trunk/Source/WebCore/platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp 2012-03-01 23:16:54 UTC (rev 109441)
+++ trunk/Source/WebCore/platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp 2012-03-01 23:17:12 UTC (rev 109442)
@@ -107,12 +107,13 @@
// Create an accelerated canvas to draw on.
OwnPtr<SkCanvas> canvas = createAcceleratedCanvas(context, allocator, texture);
- canvas->clipRect(SkRect(destRect));
// The compositor expects the textures to be upside-down so it can flip
// the final composited image. Ganesh renders the image upright so we
// need to do a y-flip.
canvas->translate(0.0, texture->size().height());
canvas->scale(1.0, -1.0);
+ // Only the region corresponding to destRect on the texture must be updated.
+ canvas->clipRect(SkRect(destRect));
// Translate the origin of contentRect to that of destRect.
// Note that destRect is defined relative to sourceRect.
canvas->translate(contentRect().x() - sourceRect.x() + destRect.x(),
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
