Title: [109443] branches/chromium/963
- Revision
- 109443
- Author
- [email protected]
- Date
- 2012-03-01 15:17:52 -0800 (Thu, 01 Mar 2012)
Log Message
Merge 109369
BUG=116224
Review URL: https://chromiumcodereview.appspot.com/9570045
Modified Paths
Added Paths
Diff
Copied: branches/chromium/963/LayoutTests/fast/frames/url-selected-crash-expected.txt (from rev 109369, trunk/LayoutTests/fast/frames/url-selected-crash-expected.txt) (0 => 109443)
--- branches/chromium/963/LayoutTests/fast/frames/url-selected-crash-expected.txt (rev 0)
+++ branches/chromium/963/LayoutTests/fast/frames/url-selected-crash-expected.txt 2012-03-01 23:17:52 UTC (rev 109443)
@@ -0,0 +1 @@
+
Copied: branches/chromium/963/LayoutTests/fast/frames/url-selected-crash.html (from rev 109369, trunk/LayoutTests/fast/frames/url-selected-crash.html) (0 => 109443)
--- branches/chromium/963/LayoutTests/fast/frames/url-selected-crash.html (rev 0)
+++ branches/chromium/963/LayoutTests/fast/frames/url-selected-crash.html 2012-03-01 23:17:52 UTC (rev 109443)
@@ -0,0 +1,24 @@
+<!DOCTYPE html>
+<html>
+<body>
+Test passes if it doesn't crash (may require libgmalloc and repeating) and this line gets erased.
+<script>
+if (window.layoutTestController) {
+ layoutTestController.dumpAsText();
+ layoutTestController.waitUntilDone();
+}
+var iterationsLeft = 2;
+function test()
+{
+ if (--iterationsLeft) {
+ frames[0].history.go(0);
+ } else {
+ document.body.textContent = frames[0].document.body.textContent;
+ if (window.layoutTestController)
+ layoutTestController.notifyDone();
+ }
+}
+</script>
+<iframe _onload_="test()"></iframe>
+</body>
+</html>
Modified: branches/chromium/963/Source/WebCore/loader/FrameLoader.cpp (109442 => 109443)
--- branches/chromium/963/Source/WebCore/loader/FrameLoader.cpp 2012-03-01 23:17:12 UTC (rev 109442)
+++ branches/chromium/963/Source/WebCore/loader/FrameLoader.cpp 2012-03-01 23:17:52 UTC (rev 109443)
@@ -252,7 +252,6 @@
void FrameLoader::changeLocation(SecurityOrigin* securityOrigin, const KURL& url, const String& referrer, bool lockHistory, bool lockBackForwardList, bool refresh)
{
- RefPtr<Frame> protect(m_frame);
urlSelected(FrameLoadRequest(securityOrigin, ResourceRequest(url, referrer, refresh ? ReloadIgnoringCacheData : UseProtocolCachePolicy), "_self"),
0, lockHistory, lockBackForwardList, MaybeSendReferrer, ReplaceDocumentIfJavaScriptURL);
}
@@ -269,6 +268,7 @@
{
ASSERT(!m_suppressOpenerInNewFrame);
+ RefPtr<Frame> protect(m_frame);
FrameLoadRequest frameRequest(passedRequest);
if (m_frame->script()->executeIfJavaScriptURL(frameRequest.resourceRequest().url(), shouldReplaceDocumentIfJavaScriptURL))
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
