Branch: refs/heads/webkitglib/2.44
Home: https://github.com/WebKit/WebKit
Commit: 5fe5d060b4a206fb396c56c07235ff788bac5475
https://github.com/WebKit/WebKit/commit/5fe5d060b4a206fb396c56c07235ff788bac5475
Author: Philippe Normand <[email protected]>
Date: 2024-04-19 (Fri, 19 Apr 2024)
Changed paths:
M Source/ThirdParty/libwebrtc/Source/webrtc/pc/legacy_stats_collector.cc
Log Message:
-----------
Cherry-pick 276753@main (753783aa83f4).
https://bugs.webkit.org/show_bug.cgi?id=271752
[LibWebRTC] Build fails with clang-18 on Linux
https://bugs.webkit.org/show_bug.cgi?id=271752
Reviewed by Youenn Fablet.
Fix -Wc++11-narrowing-const-reference warnings in LibWebRTC legacy stats
collector.
* Source/ThirdParty/libwebrtc/Source/webrtc/pc/legacy_stats_collector.cc:
Canonical link: https://commits.webkit.org/276753@main
Canonical link: https://commits.webkit.org/274313.143@webkitglib/2.44
Commit: a67b6bcf730abfb97664ddba0b4a8c14774bcd12
https://github.com/WebKit/WebKit/commit/a67b6bcf730abfb97664ddba0b4a8c14774bcd12
Author: Michael Catanzaro <[email protected]>
Date: 2024-04-19 (Fri, 19 Apr 2024)
Changed paths:
M Source/WebCore/html/PDFDocument.cpp
M Source/WebCore/html/PDFDocument.h
Log Message:
-----------
Cherry-pick 277434@main (96e3800242ca).
https://bugs.webkit.org/show_bug.cgi?id=249872
Crash in PDFDocument::injectStyleAndContentScript when downloading PDF
https://bugs.webkit.org/show_bug.cgi?id=249872
Reviewed by Tim Nguyen.
PDFDocument expects injectStyleAndContentScript to be called exactly once,
but it may be called multiple times because the EventListener is never
unregistered. So let's start by unregistering it when it's no longer needed
(which requires saving a copy of the HTMLScriptElement). I'm not sure whether
or not it's possible for a second load to start before the main resource load
finishes, so I've added an extra member variable m_injectedStyleAndScript to
really make sure we inject the user content only once, for good measure.
This fixes a crash when attempting to download certain PDF documents, but
does NOT make downloading the document actually work. It only avoids the crash.
* Source/WebCore/html/PDFDocument.cpp:
(WebCore::PDFDocumentEventListener::handleEvent):
(WebCore::PDFDocument::finishedParsing):
(WebCore::PDFDocument::finishLoadingPDF):
(WebCore::PDFDocument::injectStyleAndContentScript):
* Source/WebCore/html/PDFDocument.h:
Canonical link: https://commits.webkit.org/277434@main
Canonical link: https://commits.webkit.org/274313.144@webkitglib/2.44
Compare: https://github.com/WebKit/WebKit/compare/de9ef4916193...a67b6bcf730a
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
