Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 75f9692054bd633dfbc9768ba682d9ce43953760
https://github.com/WebKit/WebKit/commit/75f9692054bd633dfbc9768ba682d9ce43953760
Author: Vitaly Dyachkov <[email protected]>
Date: 2024-04-25 (Thu, 25 Apr 2024)
Changed paths:
M Source/WebCore/testing/WebFakeXRDevice.cpp
M Source/WebCore/testing/WebFakeXRDevice.h
Log Message:
-----------
Crash observed in running webxr layout test from
WebCore::WebXRSession::~WebXRSession()
https://bugs.webkit.org/show_bug.cgi?id=272426
Reviewed by Mike Wyrzykowski.
Since `SimulatedXRDevice` inherits from `PlatformXR::Device` which is
reference counted, `WebFakeXRDevice::m_device` should be a `Ref`.
* Source/WebCore/testing/WebFakeXRDevice.cpp:
(WebCore::WebFakeXRDevice::WebFakeXRDevice):
(WebCore::WebFakeXRDevice::setViews):
(WebCore::WebFakeXRDevice::setViewerOrigin):
(WebCore::WebFakeXRDevice::simulateVisibilityChange):
(WebCore::WebFakeXRDevice::setFloorOrigin):
(WebCore::WebFakeXRDevice::simulateInputSourceConnection):
(WebCore::WebFakeXRDevice::setSupportsShutdownNotification):
(WebCore::WebFakeXRDevice::simulateShutdown):
* Source/WebCore/testing/WebFakeXRDevice.h:
Canonical link: https://commits.webkit.org/277983@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
