Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4ce23ce267cf9ed93e79a4678caec89cb2b04e7a
https://github.com/WebKit/WebKit/commit/4ce23ce267cf9ed93e79a4678caec89cb2b04e7a
Author: Ben Schwartz <[email protected]>
Date: 2024-04-25 (Thu, 25 Apr 2024)
Changed paths:
M Tools/Scripts/webkitpy/xcode/simulated_device.py
Log Message:
-----------
[webkitpy] Fix detection of existing/uninitialized simulated devices.
https://bugs.webkit.org/show_bug.cgi?id=273226
rdar://127028481
Reviewed by Jonathan Bedard.
As part of the DeviceRequest fulfillment flow, webkitpy will first determine if
it needs
to create a new simulated device on the machine. One of the steps it takes is
to check
all existing/available simulated devices to determine if any can be used.
Currently, there is no check to make sure the device isn't currently booted.
This causes
already booted devices to be identified as eligible candidates to fulfill the
request.
This will cause a fatal error to be thrown when `xcrun simctl boot <UDID>` is
run, as
the device is already booted.
This change:
- Adds detection for if each device in the available devices list is
booted/booting.
- Changes the name of the method
`SimulatedDeviceManager._find_exisiting_device_for_request`
to `SimulatedDeviceManager._find_existing_uninitialized_device_for_request`
and add
documentation, so as to disambiguate its purpose (and fix the typo!).
* Tools/Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager._find_exisiting_device_for_request): Renamed to
_find_existing_uninitialized_device_for_request.
(SimulatedDeviceManager._create_or_find_device_for_request): Changed call to
old method to use new method name.
(SimulatedDeviceManager._find_existing_uninitialized_device_for_request): Added
check for device not already booted/booting.
Canonical link: https://commits.webkit.org/277984@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
