Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9f05a02fc85a42c92ade9dcb132d636872e54826
      
https://github.com/WebKit/WebKit/commit/9f05a02fc85a42c92ade9dcb132d636872e54826
  Author: Tyler Wilcock <[email protected]>
  Date:   2024-04-25 (Thu, 25 Apr 2024)

  Changed paths:
    M 
LayoutTests/imported/w3c/web-platform-tests/svg-aam/role/roles-generic-expected.txt
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/accessibility/AccessibilityNodeObject.h
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
    M Source/WebCore/accessibility/AccessibilitySVGElement.cpp
    M Source/WebCore/accessibility/AccessibilitySVGElement.h

  Log Message:
  -----------
  AX: SVG g elements should only be AccessibilityRole::Group if they are 
focusable or have an accname
https://bugs.webkit.org/show_bug.cgi?id=273152
rdar://problem/126946719

Reviewed by Chris Fleizach.

Per spec, SVG g elements should only be AccessibilityRole::Group if they are 
focusable or have an accname.
To support this, a new function has been added: hasAccNameAttribute. Several 
other roles performed similar,
but slightly different checks (checking for different attributes). All are now 
consistently using hasAccNameAttribute.

This patch also makes more conistent use of getAttributeTrimmed in a few places.

This allows us to pass one more WPT.

* 
LayoutTests/imported/w3c/web-platform-tests/svg-aam/role/roles-generic-expected.txt:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::hasAccNameAttribute):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const):
(WebCore::AccessibilityNodeObject::helpText const):
(WebCore::AccessibilityNodeObject::hasAccNameAttribute const):
(WebCore::AccessibilityNodeObject::hasAttributesRequiredForInclusion const):
(WebCore::AccessibilityNodeObject::determineAriaRoleAttribute const):
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::invalidStatus const):
(WebCore::AccessibilityObject::currentState const):
(WebCore::AccessibilityObject::roleDescription const):
(WebCore::AccessibilityObject::hasAttributesRequiredForInclusion const): 
Deleted.
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::hasAttributesRequiredForInclusion const):
(WebCore::AccessibilityObject::hasValidARIALabel const): Deleted.
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::helpText const):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored const):
* Source/WebCore/accessibility/AccessibilitySVGElement.cpp:
(WebCore::AccessibilitySVGElement::hasTitleOrDescChild const):
(WebCore::AccessibilitySVGElement::computeAccessibilityIsIgnored const):
(WebCore::AccessibilitySVGElement::determineAriaRoleAttribute const):
(WebCore::AccessibilitySVGElement::determineAccessibilityRole):
* Source/WebCore/accessibility/AccessibilitySVGElement.h:

Canonical link: https://commits.webkit.org/278024@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to