Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3831bd50325553b599f1eae850c2bb753d80201e
      
https://github.com/WebKit/WebKit/commit/3831bd50325553b599f1eae850c2bb753d80201e
  Author: Andres Gonzalez <[email protected]>
  Date:   2024-04-25 (Thu, 25 Apr 2024)

  Changed paths:
    M Source/WebCore/accessibility/AXCoreObject.h
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

  Log Message:
  -----------
  AX: Refactor the implementation of the NSAccessibilityChildrenAttribute API 
to avoid recursive calss.
https://bugs.webkit.org/show_bug.cgi?id=273249
<rdar://problem/127053935>

Reviewed by Tyler Wilcock.

Recursive calls to [WebAccessibilityObjectWrapper accessibilityAttributeValue:] 
have a performance impact since they will do a redundant linear search on the 
attribute name in each frame, plus call to update the backing store, create a 
new RefPtr for the backing object, etc. This patch resolves this problem for 
the NSAccessibilityChildrenAttribute API by adding the children() helper 
function and calling it instead. Includes related code cleanup.

* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::ariaTreeRows):
(WebCore::AccessibilityObject::disclosedRows):
(WebCore::AccessibilityObject::ariaSelectedRows):
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateNodeProperties):
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(transformSpecialChildrenCases):
(children):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
(-[WebAccessibilityObjectWrapper 
accessibilityArrayAttributeValues:index:maxCount:]):
(-[WebAccessibilityObjectWrapper _transformSpecialChildrenCases:]): Deleted.

Canonical link: https://commits.webkit.org/278025@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to