Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1da60c4cf12f562258cacee9a83e25c1c46e2d3b
https://github.com/WebKit/WebKit/commit/1da60c4cf12f562258cacee9a83e25c1c46e2d3b
Author: Aditya Keerthi <[email protected]>
Date: 2024-08-13 (Tue, 13 Aug 2024)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-currentcolor-computed-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-currentcolor-computed-inheritance-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-currentcolor-computed-visited-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-pseudos-computed-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-pseudos-inheritance-computed-001-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-pseudos-visited-computed-001-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/highlight-pseudos-expected.txt
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/ios/TestExpectations
M Source/JavaScriptCore/inspector/protocol/CSS.json
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/animation/WebAnimationUtilities.cpp
M Source/WebCore/css/CSSPseudoSelectors.json
M Source/WebCore/css/CSSSelector.cpp
M Source/WebCore/css/parser/CSSParserContext.cpp
M Source/WebCore/css/parser/CSSParserContext.h
M Source/WebCore/css/parser/CSSSelectorParserContext.cpp
M Source/WebCore/css/parser/CSSSelectorParserContext.h
M Source/WebCore/cssjit/SelectorCompiler.cpp
M Source/WebCore/inspector/agents/InspectorCSSAgent.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderElement.h
M Source/WebCore/rendering/RenderText.h
M Source/WebCore/rendering/StyledMarkedText.cpp
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/style/RenderStyleConstants.cpp
M Source/WebCore/rendering/style/RenderStyleConstants.h
M Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js
Log Message:
-----------
Add initial implementation for ::target-text
https://bugs.webkit.org/show_bug.cgi?id=277974
rdar://133708287
Reviewed by Tim Nguyen.
Implement `::target-text`, which represents text directly targeted by the
document URL's fragment. The behavior matches the other highlight pseudos.
Spec: https://drafts.csswg.org/css-pseudo/#highlight-selectors
* LayoutTests/TestExpectations:
There are five remaining `::target-text` test failures following this patch.
This will be individually triaged prior to enablement. Many appear to be
common issues to all highlight pseudos (ex. selection painting order) and do
not necessarily block enablement. When enabling the feature, appropriate bugs
will be filed/related to the remaining failures.
Note that "target-text-008.html" not really a new failure, as it was previously
spuriously passing. As both the test and reference file use `::target-text`, the
test is written in such a way that it trivially passes with the feature
disabled.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-currentcolor-computed-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-currentcolor-computed-inheritance-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-currentcolor-computed-visited-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-pseudos-computed-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-pseudos-inheritance-computed-001-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-pseudos-visited-computed-001-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/highlight-pseudos-expected.txt:
* LayoutTests/platform/glib/TestExpectations:
Mark a test that is failing on GTK/WPE only. This will require investigation by
someone working on the respective ports, and does not block Cocoa enablement.
* LayoutTests/platform/ios/TestExpectations:
Mark a test that is failing on iOS only. After investigation, this is not an
issue with `::target-text`, but Scroll-to-Text-Fragment in general. The issue
appears to be due to platform specific differences in SearchBuffer matching
logic. This failure does not block `::target-text` enablement, as the failure
is unrelated to the CSS feature.
* Source/JavaScriptCore/inspector/protocol/CSS.json:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/animation/WebAnimationUtilities.cpp:
(WebCore::compareStyleOriginatedAnimationOwningElementPositionsInDocumentTreeOrder):
(WebCore::pseudoElementIdentifierAsString):
* Source/WebCore/css/CSSPseudoSelectors.json:
* Source/WebCore/css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
* Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::add):
* Source/WebCore/css/parser/CSSParserContext.h:
* Source/WebCore/css/parser/CSSSelectorParserContext.cpp:
(WebCore::CSSSelectorParserContext::CSSSelectorParserContext):
(WebCore::add):
* Source/WebCore/css/parser/CSSSelectorParserContext.h:
* Source/WebCore/cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::constructFragmentsInternal):
* Source/WebCore/inspector/agents/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::protocolValueForPseudoId):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::targetTextPseudoStyle const):
* Source/WebCore/rendering/RenderElement.h:
* Source/WebCore/rendering/RenderText.h:
(WebCore::RenderText::targetTextPseudoStyle const):
* Source/WebCore/rendering/StyledMarkedText.cpp:
(WebCore::resolveStyleForMarkedText):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
* Source/WebCore/rendering/style/RenderStyleConstants.h:
* Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js:
(WI.CSSManager.displayNameForPseudoId):
Canonical link: https://commits.webkit.org/282217@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
