Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c1d8e993ab6862bb8492b4c54160287ed716e897
https://github.com/WebKit/WebKit/commit/c1d8e993ab6862bb8492b4c54160287ed716e897
Author: Ben Nham <[email protected]>
Date: 2024-08-13 (Tue, 13 Aug 2024)
Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebKit/NetworkProcess/NetworkProcess.cpp
Log Message:
-----------
Revert "Enable BuiltInNotifications by default on iOS"
https://bugs.webkit.org/show_bug.cgi?id=278062
rdar://problem/133795669
Reviewed by Sihui Liu.
Enabling built-in notifications by default on iOS (282148@main) did not work as
expected because of
how it interacts with DeprecatedGlobalSettings. The issue is that in UIProcess,
nothing actually
calls `DeprecatedGlobalSettings::setBuiltInNotifications(true)` even if you
flip the default in the
YAML file. Meanwhile, in WebProcess, `WebPage::updatePreferencesGenerated` does
call
`DeprecatedGlobalSettings::setBuiltInNotifications(true)`. So the value of
`DeprecatedGlobalSettings::builtInNotificationsEnabled()` is different in
WebContent and UIProcess,
which leads to very weird behavior (and actually some message checks start
firing).
We need to revert this and come up with a better way of changing the default.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::processPushMessage):
Canonical link: https://commits.webkit.org/282218@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
