Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4d5e21fec1e92fec08c661a383b3efec6c603a40
https://github.com/WebKit/WebKit/commit/4d5e21fec1e92fec08c661a383b3efec6c603a40
Author: Yusuke Suzuki <[email protected]>
Date: 2024-08-13 (Tue, 13 Aug 2024)
Changed paths:
M Source/WebCore/PAL/pal/spi/cocoa/ARKitSPI.h
Log Message:
-----------
Fix visionOS build error
https://bugs.webkit.org/show_bug.cgi?id=278079
rdar://problem/133812741
Reviewed by Jean-Yves Avenard.
TZone initialization header is including pas_lock.h transitively, and it
requires that `lock_private.h`
is included with OS_UNFAIR_LOCK_INLINE=1, or `lock_private.h` is not included
before. This was fine before
since pas_lock.h is very implementation deep header in libpas and FastMalloc is
hiding these bits from the
rest of the WebKit. But now TZone initialization header includes this and
exposes it, which can conflict
with some headers which already include `lock_private.h`. This time, it was
ARKitPrivate.h.
To workaround this issue, we define OS_UNFAIR_LOCK_INLINE=1 before including
ARKitPrivate.h. Long-term
robust fix needs defining OS_UNFAIR_LOCK_INLINE in Xcode configuration.
* Source/WebCore/PAL/pal/spi/cocoa/ARKitSPI.h:
Canonical link: https://commits.webkit.org/282219@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
