Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0aa547a211ad00f6c811fb509fd663b1c466cfba
https://github.com/WebKit/WebKit/commit/0aa547a211ad00f6c811fb509fd663b1c466cfba
Author: Nikolaos Mouchtaris <[email protected]>
Date: 2024-10-21 (Mon, 21 Oct 2024)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-none-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/scroll-timeline-range-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/setting-timeline.tentative-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/view-timeline-get-set-range-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/view-timeline-range-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/view-timeline-root-source-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/view-timeline-subject-size-changes-expected.txt
M Source/WebCore/animation/AnimationTimeline.h
M Source/WebCore/animation/DocumentTimeline.cpp
M Source/WebCore/animation/DocumentTimeline.h
M Source/WebCore/animation/ScrollTimeline.cpp
M Source/WebCore/animation/ScrollTimeline.h
M Source/WebCore/animation/TimelineRange.cpp
M Source/WebCore/animation/TimelineRange.h
M Source/WebCore/animation/ViewTimeline.cpp
M Source/WebCore/animation/ViewTimeline.h
M Source/WebCore/animation/WebAnimation.cpp
M Source/WebCore/animation/WebAnimation.h
M Source/WebCore/style/StyleBuilderConverter.h
Log Message:
-----------
[scroll-animations] Pass animation range value down into computeTimelineData
https://bugs.webkit.org/show_bug.cgi?id=281543
rdar://138006146
Reviewed by Tim Nguyen and Antoine Quint.
When calculating WebAnimation::currentTime, pass down any associated animation
range down into
computeTimelineData. Also add parsing code for the JS api, reusing the parsing
code for the CSS
portion. Also fix some various bugs about computing the timeline data using the
animation range
value.
* Source/WebCore/animation/AnimationTimeline.h:
(WebCore::AnimationTimeline::currentTime):
* Source/WebCore/animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::currentTime):
* Source/WebCore/animation/DocumentTimeline.h:
* Source/WebCore/animation/ScrollTimeline.cpp:
(WebCore::ScrollTimeline::computeTimelineData const):
(WebCore::ScrollTimeline::currentTime):
* Source/WebCore/animation/ScrollTimeline.h:
(WebCore::ScrollTimeline::currentTime):
(WebCore::ScrollTimeline::computeTimelineData):
* Source/WebCore/animation/TimelineRange.cpp:
(WebCore::SingleTimelineRange::defaultValue):
(WebCore::SingleTimelineRange::serialize const):
(WebCore::lengthFoCSSValue):
(WebCore::SingleTimelineRange::range):
(WebCore::SingleTimelineRange::parse):
(WebCore::TimelineRange::defaultForViewTimeline):
* Source/WebCore/animation/TimelineRange.h:
(WebCore::TimelineRange::isDefault const):
* Source/WebCore/animation/ViewTimeline.cpp:
(WebCore::ViewTimeline::computeTimelineData const):
* Source/WebCore/animation/ViewTimeline.h:
* Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::currentTime const):
(WebCore::WebAnimation::setRangeStart):
(WebCore::WebAnimation::setRangeEnd):
* Source/WebCore/animation/WebAnimation.h:
(WebCore::WebAnimation::rangeStart const):
(WebCore::WebAnimation::rangeEnd const):
(WebCore::WebAnimation::setRangeStart): Deleted.
(WebCore::WebAnimation::setRangeEnd): Deleted.
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertAnimationRangeStart):
(WebCore::Style::BuilderConverter::convertAnimationRangeEnd):
(WebCore::Style::BuilderConverter::convertAnimationRange): Deleted.
Canonical link: https://commits.webkit.org/285533@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
