Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a2d7b437363eb63ebd9a4abd1850545f248a6f49
https://github.com/WebKit/WebKit/commit/a2d7b437363eb63ebd9a4abd1850545f248a6f49
Author: Keith Miller <[email protected]>
Date: 2024-11-17 (Sun, 17 Nov 2024)
Changed paths:
M Source/JavaScriptCore/runtime/OptionsList.h
M Source/JavaScriptCore/wasm/WasmCalleeGroup.cpp
M Source/JavaScriptCore/wasm/WasmCalleeGroup.h
Log Message:
-----------
Re-enable GCing wasm BBQ/OMGOSR code
https://bugs.webkit.org/show_bug.cgi?id=283205
rdar://140004763
Reviewed by Yusuke Suzuki and Justin Michaud.
This patch fixes a crasher we hit that caused us to disable GCing wasm
BBQ/OMGOSR code.
The issue was that I assumed we only compiled OMGPlans when there was a
BBQ::Callee of
the same memory mode. This isn't always the case, since we can run
BoundsChecking code
for a Signaling memory. The solution is just to remove BBQ::Callees only when
they exist.
Since this was the only remaining issue with GCing wasm BBQ/OMGOSR code this
patch
reenables it.
* Source/JavaScriptCore/runtime/OptionsList.h:
* Source/JavaScriptCore/wasm/WasmCalleeGroup.cpp:
(JSC::Wasm::CalleeGroup::releaseBBQCallee):
(JSC::Wasm::CalleeGroup::reportCallees):
* Source/JavaScriptCore/wasm/WasmCalleeGroup.h:
Canonical link: https://commits.webkit.org/286705@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
