Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 169dfb0cbc4012bfad05ba1a467d207def698d33
https://github.com/WebKit/WebKit/commit/169dfb0cbc4012bfad05ba1a467d207def698d33
Author: Sam Weinig <[email protected]>
Date: 2024-11-17 (Sun, 17 Nov 2024)
Changed paths:
M Source/WebCore/Modules/web-locks/WebLockGrantedCallback.h
M Source/WebCore/Modules/web-locks/WebLockManager.cpp
M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
M Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionRethrow.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionRethrow.h
M Source/WebCore/bindings/scripts/test/JS/JSTestCallbackInterface.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestCallbackInterface.h
M Source/WebCore/dom/CreateHTMLCallback.h
M Source/WebCore/dom/CreateScriptCallback.h
M Source/WebCore/dom/CreateScriptURLCallback.h
M Source/WebCore/dom/InternalObserverDrop.cpp
M Source/WebCore/dom/InternalObserverEvery.cpp
M Source/WebCore/dom/InternalObserverFilter.cpp
M Source/WebCore/dom/InternalObserverFind.cpp
M Source/WebCore/dom/InternalObserverForEach.cpp
M Source/WebCore/dom/InternalObserverMap.cpp
M Source/WebCore/dom/InternalObserverSome.cpp
M Source/WebCore/dom/InternalObserverTake.cpp
M Source/WebCore/dom/MapperCallback.h
M Source/WebCore/dom/NativeNodeFilter.cpp
M Source/WebCore/dom/NativeNodeFilter.h
M Source/WebCore/dom/NodeFilter.h
M Source/WebCore/dom/Observable.cpp
M Source/WebCore/dom/PredicateCallback.h
M Source/WebCore/dom/SubscriberCallback.h
M Source/WebCore/dom/Traversal.cpp
M Source/WebCore/dom/TrustedTypePolicy.cpp
M Source/WebCore/dom/VisitorCallback.h
M Source/WebKitLegacy/mac/DOM/DOM.mm
Log Message:
-----------
[WebIDL] Callbacks should leave the choice to report or rethrow exceptions to
the invoker (part 1, rename rethrowing handler)
https://bugs.webkit.org/show_bug.cgi?id=283177
Reviewed by Chris Dumez.
Part 1 of a series to move the decision choice of a WebIDL callback to report
exceptions
or rethrow them to the caller instead of it being baked into the type.
This initial change keeps the extended attribute, [RethrowException], but has
it update
the name of the callback method from <name>(...) to
<name>RethrowingException(...).
* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallbackHeaderContent):
(GenerateCallbackImplementationContent):
- Update handler name to have the `RethrowingException` suffix if
[RethrowException] is present.
* Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionRethrow.cpp:
* Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionRethrow.h:
* Source/WebCore/bindings/scripts/test/JS/JSTestCallbackInterface.cpp:
* Source/WebCore/bindings/scripts/test/JS/JSTestCallbackInterface.h:
- Update test bindings test generation results for new name.
* Source/WebCore/Modules/web-locks/WebLockGrantedCallback.h:
* Source/WebCore/Modules/web-locks/WebLockManager.cpp:
* Source/WebCore/dom/CreateHTMLCallback.h:
* Source/WebCore/dom/CreateScriptCallback.h:
* Source/WebCore/dom/CreateScriptURLCallback.h:
* Source/WebCore/dom/InternalObserverDrop.cpp:
* Source/WebCore/dom/InternalObserverEvery.cpp:
* Source/WebCore/dom/InternalObserverFilter.cpp:
* Source/WebCore/dom/InternalObserverFind.cpp:
* Source/WebCore/dom/InternalObserverForEach.cpp:
* Source/WebCore/dom/InternalObserverMap.cpp:
* Source/WebCore/dom/InternalObserverSome.cpp:
* Source/WebCore/dom/InternalObserverTake.cpp:
* Source/WebCore/dom/MapperCallback.h:
* Source/WebCore/dom/NativeNodeFilter.cpp:
* Source/WebCore/dom/NativeNodeFilter.h:
* Source/WebCore/dom/NodeFilter.h:
* Source/WebCore/dom/Observable.cpp:
* Source/WebCore/dom/PredicateCallback.h:
* Source/WebCore/dom/SubscriberCallback.h:
* Source/WebCore/dom/Traversal.cpp:
* Source/WebCore/dom/TrustedTypePolicy.cpp:
* Source/WebCore/dom/VisitorCallback.h:
* Source/WebKitLegacy/mac/DOM/DOM.mm:
Update implementations and callers to new names.
Canonical link: https://commits.webkit.org/286706@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
