Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 552412a60855dc2f31ee9ea3f9efe7620f49e4a3
      
https://github.com/WebKit/WebKit/commit/552412a60855dc2f31ee9ea3f9efe7620f49e4a3
  Author: Alan Baradlay <[email protected]>
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
    M Source/WebCore/layout/floats/FloatingContext.cpp
    M Source/WebCore/layout/floats/FloatingContext.h

  Log Message:
  -----------
  [Cleanup][Floats] Use BlockFormattingContext(Root) in FloatingContext when 
referring to PlacedFloats's root
https://bugs.webkit.org/show_bug.cgi?id=283251

Reviewed by Antti Koivisto.

PlacedFloats's root is always a BFC (where the FloatingContext's root is always 
an IFC).
Let's use the phrase of BlockFormattingContext(root) whenever we convert coords 
between
FloatingContext and PlacedFloats.

* Source/WebCore/layout/floats/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::positionForFloat const):
(WebCore::Layout::FloatingContext::verticalPositionWithClearance const):
(WebCore::Layout::FloatingContext::constraints const):
(WebCore::Layout::FloatingContext::makeFloatItem const):
(WebCore::Layout::FloatingContext::absoluteCoordinates const):
(WebCore::Layout::FloatingContext::mapTopLeftToBlockFormattingContextRoot 
const):
(WebCore::Layout::FloatingContext::mapPointFromFloatingContextRootToBlockFormattingContextRoot
 const):
(WebCore::Layout::FloatingContext::isStartPositioned const):
(WebCore::Layout::FloatingContext::isFloatingCandidateStartPositionedInBlockFormattingContext
 const):
(WebCore::Layout::FloatingContext::clearInBlockFormattingContext const):
(WebCore::Layout::FloatingContext::mapTopLeftToPlacedFloatsRoot const): Deleted.
(WebCore::Layout::FloatingContext::mapPointFromFormattingContextRootToPlacedFloatsRoot
 const): Deleted.
(WebCore::Layout::FloatingContext::isFloatingCandidateStartPositionedInPlacedFloats
 const): Deleted.
(WebCore::Layout::FloatingContext::clearInPlacedFloats const): Deleted.
* Source/WebCore/layout/floats/FloatingContext.h:

Canonical link: https://commits.webkit.org/286728@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to