Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7d3cb9238db77f66577af7605a78d2a19213b3cf
      
https://github.com/WebKit/WebKit/commit/7d3cb9238db77f66577af7605a78d2a19213b3cf
  Author: Antoine Quint <[email protected]>
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/inline-subject-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/svg-graphics-element-001-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/svg-graphics-element-002-expected.txt
    M Source/WebCore/animation/ViewTimeline.cpp

  Log Message:
  -----------
  [scroll-animations] view timelines should support inline and SVG subjects
https://bugs.webkit.org/show_bug.cgi?id=283291
rdar://140111170

Reviewed by Antti Koivisto.

We only supported elements with a `RenderBox` renderer as subjects for view 
timelines,
thus excluding inlines and SVG elements. This made a few tests time out because 
their
`ready` promise never `resolved` as their timeline never reports a resolved 
current time.

We now add support for `RenderInline`, `RenderSVGModelObject` and 
`LegacyRenderSVGModelObject`
renderers which makes the affected tests pass.

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/inline-subject-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/svg-graphics-element-001-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/svg-graphics-element-002-expected.txt:
* Source/WebCore/animation/ViewTimeline.cpp:
(WebCore::ViewTimeline::computeTimelineData const):

Canonical link: https://commits.webkit.org/286724@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to