Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 304f4c84488566cd1eaca311b7337d8c17359316
https://github.com/WebKit/WebKit/commit/304f4c84488566cd1eaca311b7337d8c17359316
Author: Tyler Wilcock <[email protected]>
Date: 2024-11-18 (Mon, 18 Nov 2024)
Changed paths:
M Source/WebCore/accessibility/AXCoreObject.cpp
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AXLogger.cpp
M Source/WebCore/accessibility/AccessibilityListBox.cpp
M Source/WebCore/accessibility/AccessibilityListBox.h
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.h
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/AccessibilitySlider.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
Log Message:
-----------
AX: Remove redundant properties AXPropertyName::{CanSetSelectedChildren,
IsControl, SupportsRequiredAttribute} and make supports-style property pairs
more efficient to initialize
https://bugs.webkit.org/show_bug.cgi?id=283237
rdar://140047221
Reviewed by Chris Fleizach.
AXPropertyName::{CanSetSelectedChildren, IsControl, SupportsRequiredAttribute}
can all be computed in terms of data
we already cache, so this commit removes them. This makes creating every object
cheaper and saves memory.
This commit also improves the initialization of supports-style properties more
efficient in AXIsolatedObject::initializeProperties
by only computing fooValue() if the object supportsFooValue() (e.g.
supportsExpandedTextValue() + expandedTextValue()).
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::isControl const):
(WebCore::AXCoreObject::supportsRequiredAttribute const):
* Source/WebCore/accessibility/AXCoreObject.h:
(WebCore::AXCoreObject::canSetSelectedChildren const):
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::canSetSelectedChildren const): Deleted.
* Source/WebCore/accessibility/AccessibilityListBox.h:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::supportsRequiredAttribute const): Deleted.
(WebCore::AccessibilityNodeObject::isControl const): Deleted.
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isSliderThumb const):
* Source/WebCore/accessibility/AccessibilitySlider.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):
(WebCore::AXIsolatedObject::setProperty):
(WebCore::AXIsolatedObject::boolAttributeValue const):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
Canonical link: https://commits.webkit.org/286731@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
