Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2382284aaa9b912ead87f5be2102493d7523d28a
https://github.com/WebKit/WebKit/commit/2382284aaa9b912ead87f5be2102493d7523d28a
Author: Alan Baradlay <[email protected]>
Date: 2024-11-18 (Mon, 18 Nov 2024)
Changed paths:
A LayoutTests/fast/text/inline-box-with-underline-skip-none-expected.html
A LayoutTests/fast/text/inline-box-with-underline-skip-none.html
M Source/WebCore/rendering/TextDecorationPainter.cpp
M Source/WebCore/rendering/TextDecorationPainter.h
Log Message:
-----------
Underline stays 'skip' on MND's text-decoration-skip-ink page (Try it section)
https://bugs.webkit.org/show_bug.cgi?id=283226
Reviewed by Antti Koivisto.
text-decoration-skip-ink is not part of the decorating box context. An inline
box
can have text-decoration-skip-ink set while not having any decoration style.
e.g.
<div style="text-decoration: underline">
<span style="text-decoration-skip-ink: none">has underline but with skip
none</span>
</div>
Such combination would make the inline box a non-decorating box in
TextBoxPainer, while also triggering drawing underline through the propagated
decorating setup.
Let's use the text-decoration-skip-ink value from the ancestor inline box and
not from the decorating box.
* LayoutTests/fast/text/inline-box-with-underline-skip-none-expected.html:
Added.
* LayoutTests/fast/text/inline-box-with-underline-skip-none.html: Added.
* Source/WebCore/rendering/TextDecorationPainter.cpp:
(WebCore::TextDecorationPainter::paintBackgroundDecorations):
(WebCore::TextDecorationPainter::stylesForRenderer):
* Source/WebCore/rendering/TextDecorationPainter.h:
Canonical link: https://commits.webkit.org/286730@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
