Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ccdf9fadf057cccdb9b080ac40a1031fddc9bf6d
https://github.com/WebKit/WebKit/commit/ccdf9fadf057cccdb9b080ac40a1031fddc9bf6d
Author: Elika Etemad <[email protected]>
Date: 2025-01-02 (Thu, 02 Jan 2025)
Changed paths:
M Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.cpp
Log Message:
-----------
Teach IFC input to convert margin/padding/border for writing-mode: sideways-lr
https://bugs.webkit.org/show_bug.cgi?id=285274
rdar://142226484
Reviewed by Alan Baradlay.
This updates the physical->logical coordinate mapping functions for
inline layout to handle writing-mode: sideways properly.
It also renames the internal variables in these mapping functions to
use consistent directional terms that avoid avoid confusion between
"logical left" (which means the top/left edge in the inline axis)
and the inline start (which is what IFC uses).
* Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.cpp:
(WebCore::LayoutIntegration::BoxGeometryUpdater::horizontalLogicalMargin): Use
consistent variable names.
(WebCore::LayoutIntegration::BoxGeometryUpdater::verticalLogicalMargin): Handle
sideways-lr mapping.
(WebCore::LayoutIntegration::BoxGeometryUpdater::logicalBorder): Handle
sideways-lr mapping; use better variable names.
(WebCore::LayoutIntegration::BoxGeometryUpdater::logicalPadding): Handle
sideways-lr mapping; use better variable names.
(WebCore::LayoutIntegration::BoxGeometryUpdater::formattingContextConstraints):
Handle sideways-lr mapping.
Canonical link: https://commits.webkit.org/288379@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
