Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ce9e73cd2b64b18416c8e25d001915eb022c62fd
https://github.com/WebKit/WebKit/commit/ce9e73cd2b64b18416c8e25d001915eb022c62fd
Author: Elika Etemad <[email protected]>
Date: 2025-01-02 (Thu, 02 Jan 2025)
Changed paths:
M
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h
M
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp
Log Message:
-----------
Cosmetic improvements to InlineDisplay*Builder coordinate mapping
https://bugs.webkit.org/show_bug.cgi?id=285275
rdar://problem/142227210
Reviewed by Alan Baradlay.
- Adopt line-relative terminology to shorten variable and function names.
- Use "logical left" and "logical right" consistent with their usage in
RenderBlock etc.
- Pass around writingMode objects directly; and clarify whose writingMode it is.
- Reorganize InlineDisplayLineBuilder::build to organize its calculations
better;
and in particular to build a logicalRect that can in the future be passed to a
standard mapping function
*
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::marginLineLeft):
(WebCore::Layout::marginLineRight):
(WebCore::Layout::borderLineLeft):
(WebCore::Layout::borderLineRight):
(WebCore::Layout::paddingLineLeft):
(WebCore::Layout::paddingLineRight):
(WebCore::Layout::InlineDisplayContentBuilder::adjustVisualGeometryForDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):
(WebCore::Layout::InlineDisplayContentBuilder::setLogicalLeft const):
(WebCore::Layout::InlineDisplayContentBuilder::setLogicalRight const):
(WebCore::Layout::marginLeftInInlineDirection): Deleted.
(WebCore::Layout::marginRightInInlineDirection): Deleted.
(WebCore::Layout::borderLeftInInlineDirection): Deleted.
(WebCore::Layout::borderRightInInlineDirection): Deleted.
(WebCore::Layout::paddingLeftInInlineDirection): Deleted.
(WebCore::Layout::paddingRightInInlineDirection): Deleted.
(WebCore::Layout::InlineDisplayContentBuilder::setLeftForWritingMode const):
Deleted.
(WebCore::Layout::InlineDisplayContentBuilder::setRightForWritingMode const):
Deleted.
*
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h:
*
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp:
(WebCore::Layout::InlineDisplayLineBuilder::build const):
Canonical link: https://commits.webkit.org/288380@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
