Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 590e5e3c35ae826e28d68e40d6b15f8c8cd9ef63
https://github.com/WebKit/WebKit/commit/590e5e3c35ae826e28d68e40d6b15f8c8cd9ef63
Author: Philippe Normand <[email protected]>
Date: 2025-01-22 (Wed, 22 Jan 2025)
Changed paths:
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
M Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.h
Log Message:
-----------
REGRESSION(288690@main): [GStreamer] Broke non-GL video rendering
https://bugs.webkit.org/show_bug.cgi?id=286351
Reviewed by Xabier Rodriguez-Calvar.
The main issue was that our video sink was trying to chain to non-existent
unlock and unlock_stop
basesink methods. Driving-by the code was cleaned-up a bit as well.
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::registerWebKitGStreamerElements):
* Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkRequestRender):
(webkitVideoSinkUnlock):
(webkitVideoSinkUnlockStop):
(webkitVideoSinkStop):
(webkitVideoSinkSetCaps):
(webkitVideoSinkEvent):
(_WebKitVideoSinkPrivate::_WebKitVideoSinkPrivate): Deleted.
(_WebKitVideoSinkPrivate::~_WebKitVideoSinkPrivate): Deleted.
* Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.h:
Canonical link: https://commits.webkit.org/289238@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
