Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8c0cb740717964ee895a5abf2464c48da408b649
https://github.com/WebKit/WebKit/commit/8c0cb740717964ee895a5abf2464c48da408b649
Author: Anne van Kesteren <[email protected]>
Date: 2025-02-18 (Tue, 18 Feb 2025)
Changed paths:
A
LayoutTests/fast/shadow-dom/cannot-hit-test-into-shadow-color-input-expected.txt
A LayoutTests/fast/shadow-dom/cannot-hit-test-into-shadow-color-input.html
A
LayoutTests/fast/shadow-dom/cannot-hit-test-into-shadow-file-input-expected.txt
A LayoutTests/fast/shadow-dom/cannot-hit-test-into-shadow-file-input.html
A LayoutTests/fast/shadow-dom/cannot-hit-test-into-shadow-media-expected.txt
A LayoutTests/fast/shadow-dom/cannot-hit-test-into-shadow-media.html
A
LayoutTests/fast/shadow-dom/cannot-hit-test-into-shadow-range-input-expected.txt
A LayoutTests/fast/shadow-dom/cannot-hit-test-into-shadow-range-input.html
A
LayoutTests/fast/shadow-dom/cannot-hit-test-into-shadow-textarea-expected.txt
A LayoutTests/fast/shadow-dom/cannot-hit-test-into-shadow-textarea.html
R
LayoutTests/fast/shadow-dom/color-input-element-shadow-manipulation-expected.txt
R LayoutTests/fast/shadow-dom/color-input-element-shadow-manipulation.html
R
LayoutTests/fast/shadow-dom/file-input-element-shadow-manipulation-expected.txt
R LayoutTests/fast/shadow-dom/file-input-element-shadow-manipulation.html
R LayoutTests/fast/shadow-dom/keygen-shadow-manipulation-expected.txt
R LayoutTests/fast/shadow-dom/keygen-shadow-manipulation.html
R LayoutTests/fast/shadow-dom/media-shadow-manipulation-expected.txt
R LayoutTests/fast/shadow-dom/media-shadow-manipulation.html
R
LayoutTests/fast/shadow-dom/range-input-element-shadow-manipulation-expected.txt
R LayoutTests/fast/shadow-dom/range-input-element-shadow-manipulation.html
R LayoutTests/fast/shadow-dom/textarea-shadow-manipulation-expected.txt
R LayoutTests/fast/shadow-dom/textarea-shadow-manipulation.html
M Source/WebCore/html/ColorInputType.cpp
M Source/WebCore/html/FileInputType.cpp
M Source/WebCore/html/HTMLTextAreaElement.cpp
M Source/WebCore/html/RangeInputType.cpp
M Source/WebCore/svg/SVGUseElement.cpp
Log Message:
-----------
Be stricter about user agent shadow trees
https://bugs.webkit.org/show_bug.cgi?id=287797
Reviewed by Ryosuke Niwa.
182831@main changed the way we obtain user agent shadow tree children
due to a bug in document.caretRangeFromPoint that got fixed in
183150@main whereby websites could get access to the user agent shadow
tree children.
As we generally assume and should enforce that websites do not have
access to user agent shadow tree children, this change removes the
allowance for elements to be in various places in the user agent shadow
tree and will instead crash (safely) when that nevertheless happens.
We also update the tests to instead be document.caretRangeFromPoint
tests. The failure for the video element has been recorded as
https://bugs.webkit.org/show_bug.cgi?id=287796.
The <keygen> element test is removed as that element has been removed a
while back.
*
LayoutTests/fast/shadow-dom/cannot-hit-test-into-shadow-color-input-expected.txt:
Added.
* LayoutTests/fast/shadow-dom/cannot-hit-test-into-shadow-color-input.html:
Added.
*
LayoutTests/fast/shadow-dom/cannot-hit-test-into-shadow-file-input-expected.txt:
Added.
* LayoutTests/fast/shadow-dom/cannot-hit-test-into-shadow-file-input.html:
Added.
* LayoutTests/fast/shadow-dom/cannot-hit-test-into-shadow-media-expected.txt:
Added.
* LayoutTests/fast/shadow-dom/cannot-hit-test-into-shadow-media.html: Added.
*
LayoutTests/fast/shadow-dom/cannot-hit-test-into-shadow-range-input-expected.txt:
Added.
* LayoutTests/fast/shadow-dom/cannot-hit-test-into-shadow-range-input.html:
Added.
*
LayoutTests/fast/shadow-dom/cannot-hit-test-into-shadow-textarea-expected.txt:
Added.
* LayoutTests/fast/shadow-dom/cannot-hit-test-into-shadow-textarea.html: Added.
*
LayoutTests/fast/shadow-dom/color-input-element-shadow-manipulation-expected.txt:
Removed.
* LayoutTests/fast/shadow-dom/color-input-element-shadow-manipulation.html:
Removed.
*
LayoutTests/fast/shadow-dom/file-input-element-shadow-manipulation-expected.txt:
Removed.
* LayoutTests/fast/shadow-dom/file-input-element-shadow-manipulation.html:
Removed.
* LayoutTests/fast/shadow-dom/keygen-shadow-manipulation-expected.txt: Removed.
* LayoutTests/fast/shadow-dom/keygen-shadow-manipulation.html: Removed.
* LayoutTests/fast/shadow-dom/media-shadow-manipulation-expected.txt: Removed.
* LayoutTests/fast/shadow-dom/media-shadow-manipulation.html: Removed.
*
LayoutTests/fast/shadow-dom/range-input-element-shadow-manipulation-expected.txt:
Removed.
* LayoutTests/fast/shadow-dom/range-input-element-shadow-manipulation.html:
Removed.
* LayoutTests/fast/shadow-dom/textarea-shadow-manipulation-expected.txt:
Removed.
* LayoutTests/fast/shadow-dom/textarea-shadow-manipulation.html: Removed.
* Source/WebCore/html/ColorInputType.cpp:
(WebCore::ColorInputType::shadowColorSwatch const):
* Source/WebCore/html/FileInputType.cpp:
(WebCore::fileSelectorButton):
* Source/WebCore/html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::innerTextElement const):
* Source/WebCore/html/RangeInputType.cpp:
(WebCore::RangeInputType::sliderTrackElement const):
(WebCore::RangeInputType::typedSliderThumbElement const):
* Source/WebCore/svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::targetClone const):
Canonical link: https://commits.webkit.org/290542@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
