Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8fed05a6d280f20551c787e5e4a9ddcce8988bda
      
https://github.com/WebKit/WebKit/commit/8fed05a6d280f20551c787e5e4a9ddcce8988bda
  Author: Mike Wyrzykowski <mwyrzykow...@apple.com>
  Date:   2025-03-26 (Wed, 26 Mar 2025)

  Changed paths:
    M Source/WebGPU/WebGPU/Queue.mm

  Log Message:
  -----------
  [WebGPU] Assert command buffers complete successfully or with known errors
https://bugs.webkit.org/show_bug.cgi?id=290473
rdar://145582227

Reviewed by Cameron McCormack.

Some malicous workloads can cause GPU hangs as proving
a shader executes in a finite period of time is not only
NP-complete but would require memory synchronization impacting
performance greatly.

Release assert this never occurs, as it would only occur with
malicous or invalid workloads (e.g., programmer error). When
this does occur, not only are Metal resources WebGPU created in
a potentially inconsistent state, so any validation could be defeated,
but so are other Metal resources created from WebKit.

No test as we can not test a GPU hang without impacting other tests.

Note the constants are not public, but are trivially discoverable
via logging the NSError* on the MTLComandBuffer.

* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::commitMTLCommandBuffer):

Canonical link: https://commits.webkit.org/292741@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to