Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ba2c835382ffc38a8f18c4693c6dc6d50c3b4ab3 https://github.com/WebKit/WebKit/commit/ba2c835382ffc38a8f18c4693c6dc6d50c3b4ab3 Author: Yusuke Suzuki <ysuz...@apple.com> Date: 2025-03-29 (Sat, 29 Mar 2025)
Changed paths: M Source/JavaScriptCore/runtime/BrandedStructure.h M Source/JavaScriptCore/runtime/Structure.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyGCStructure.h Log Message: ----------- [JSC] Just use destructor of Structures https://bugs.webkit.org/show_bug.cgi?id=290674 rdar://148145512 Reviewed by Keith Miller. BrandedStructure::destruct / WebAssemblyGCStructure::destruct are error-prone since we need to list up all destructible members manually. If we missed something, then it will be leaked. Instead we should just use normal destructor, and we should dispatch the destructor in Structure::destroy function. * Source/JavaScriptCore/runtime/BrandedStructure.h: * Source/JavaScriptCore/runtime/Structure.cpp: (JSC::Structure::destroy): (JSC::Structure::~Structure): Deleted. * Source/JavaScriptCore/wasm/js/WebAssemblyGCStructure.h: Canonical link: https://commits.webkit.org/292894@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes