Title: [112494] trunk/Source/WebCore
- Revision
- 112494
- Author
- [email protected]
- Date
- 2012-03-28 19:32:50 -0700 (Wed, 28 Mar 2012)
Log Message
[BlackBerry]Missing cookies from HTTP response header in Network tab of Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=82041
We shouldn't overwrite cookies of response if there are more than one
header of Set-Cookie.
Patch by Jason Liu <[email protected]> on 2012-03-28
Reviewed by Rob Buis.
Test: http/tests/cookies/resources/setArraycookies.php
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyHeaderReceived):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (112493 => 112494)
--- trunk/Source/WebCore/ChangeLog 2012-03-29 02:18:18 UTC (rev 112493)
+++ trunk/Source/WebCore/ChangeLog 2012-03-29 02:32:50 UTC (rev 112494)
@@ -1,3 +1,18 @@
+2012-03-28 Jason Liu <[email protected]>
+
+ [BlackBerry]Missing cookies from HTTP response header in Network tab of Web Inspector.
+ https://bugs.webkit.org/show_bug.cgi?id=82041
+
+ We shouldn't overwrite cookies of response if there are more than one
+ header of Set-Cookie.
+
+ Reviewed by Rob Buis.
+
+ Test: http/tests/cookies/resources/setArraycookies.php
+
+ * platform/network/blackberry/NetworkJob.cpp:
+ (WebCore::NetworkJob::handleNotifyHeaderReceived):
+
2012-03-28 Noel Gordon <[email protected]>
JPEGImageDecoder: Set frame alpha state before marking a frame complete
Modified: trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp (112493 => 112494)
--- trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp 2012-03-29 02:18:18 UTC (rev 112493)
+++ trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp 2012-03-29 02:32:50 UTC (rev 112494)
@@ -306,6 +306,11 @@
if (m_frame && m_frame->page() && m_frame->loader() && m_frame->loader()->client()
&& static_cast<FrameLoaderClientBlackBerry*>(m_frame->loader()->client())->cookiesEnabled())
handleSetCookieHeader(value);
+
+ if (m_response.httpHeaderFields().contains("Set-Cookie")) {
+ m_response.setHTTPHeaderField(key, m_response.httpHeaderField(key) + "\r\n" + value);
+ return;
+ }
}
if (lowerKey == "www-authenticate")
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
