Title: [112496] trunk/Source/_javascript_Core
Revision
112496
Author
[email protected]
Date
2012-03-28 20:00:19 -0700 (Wed, 28 Mar 2012)

Log Message

minidom configurations should be based on ToolExecutable.xcconfig
<http://webkit.org/b/82513>

Reviewed by Mark Rowe.

Note that this patch changes minidom from being installed in
/usr/local/bin to _javascript_Core.framework/Resources.

* Configurations/ToolExecutable.xcconfig: Add semi-colon.
* _javascript_Core.xcodeproj/project.pbxproj: Base minidom
configurations on ToolExecutable.xcconfig.  Remove redundant
PRODUCT_NAME and SKIP_INSTALL variables.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (112495 => 112496)


--- trunk/Source/_javascript_Core/ChangeLog	2012-03-29 02:57:04 UTC (rev 112495)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-03-29 03:00:19 UTC (rev 112496)
@@ -1,3 +1,18 @@
+2012-03-28  David Kilzer  <[email protected]>
+
+        minidom configurations should be based on ToolExecutable.xcconfig
+        <http://webkit.org/b/82513>
+
+        Reviewed by Mark Rowe.
+
+        Note that this patch changes minidom from being installed in
+        /usr/local/bin to _javascript_Core.framework/Resources.
+
+        * Configurations/ToolExecutable.xcconfig: Add semi-colon.
+        * _javascript_Core.xcodeproj/project.pbxproj: Base minidom
+        configurations on ToolExecutable.xcconfig.  Remove redundant
+        PRODUCT_NAME and SKIP_INSTALL variables.
+
 2012-03-28  Gavin Barraclough  <[email protected]>
 
         Build fix - some compiles generating NORETURN related warnings.

Modified: trunk/Source/_javascript_Core/Configurations/ToolExecutable.xcconfig (112495 => 112496)


--- trunk/Source/_javascript_Core/Configurations/ToolExecutable.xcconfig	2012-03-29 02:57:04 UTC (rev 112495)
+++ trunk/Source/_javascript_Core/Configurations/ToolExecutable.xcconfig	2012-03-29 03:00:19 UTC (rev 112496)
@@ -21,7 +21,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
-INSTALL_PATH = $(_javascript_CORE_FRAMEWORKS_DIR)/_javascript_Core.framework/Resources
+INSTALL_PATH = $(_javascript_CORE_FRAMEWORKS_DIR)/_javascript_Core.framework/Resources;
 PRODUCT_NAME = $(TARGET_NAME);
 
 SKIP_INSTALL = $(SKIP_INSTALL_$(FORCE_TOOL_INSTALL));

Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (112495 => 112496)


--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2012-03-29 02:57:04 UTC (rev 112495)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2012-03-29 03:00:19 UTC (rev 112496)
@@ -3189,25 +3189,22 @@
 		};
 		1412113A0A48798400480255 /* Debug */ = {
 			isa = XCBuildConfiguration;
+			baseConfigurationReference = BC021BF2136900C300FC5467 /* ToolExecutable.xcconfig */;
 			buildSettings = {
-				PRODUCT_NAME = minidom;
-				SKIP_INSTALL = YES;
 			};
 			name = Debug;
 		};
 		1412113B0A48798400480255 /* Release */ = {
 			isa = XCBuildConfiguration;
+			baseConfigurationReference = BC021BF2136900C300FC5467 /* ToolExecutable.xcconfig */;
 			buildSettings = {
-				PRODUCT_NAME = minidom;
-				SKIP_INSTALL = YES;
 			};
 			name = Release;
 		};
 		1412113C0A48798400480255 /* Production */ = {
 			isa = XCBuildConfiguration;
+			baseConfigurationReference = BC021BF2136900C300FC5467 /* ToolExecutable.xcconfig */;
 			buildSettings = {
-				PRODUCT_NAME = minidom;
-				SKIP_INSTALL = YES;
 			};
 			name = Production;
 		};
@@ -3405,9 +3402,8 @@
 		};
 		A76148410E6402F700E357FA /* Profiling */ = {
 			isa = XCBuildConfiguration;
+			baseConfigurationReference = BC021BF2136900C300FC5467 /* ToolExecutable.xcconfig */;
 			buildSettings = {
-				PRODUCT_NAME = minidom;
-				SKIP_INSTALL = YES;
 			};
 			name = Profiling;
 		};
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to