Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4142580276a38fa413fb95c6edf45796ba81a622
https://github.com/WebKit/WebKit/commit/4142580276a38fa413fb95c6edf45796ba81a622
Author: Chris Dumez <[email protected]>
Date: 2025-04-08 (Tue, 08 Apr 2025)
Changed paths:
M Source/JavaScriptCore/API/JSValue.mm
M Source/WTF/wtf/cocoa/FileSystemCocoa.mm
M Source/WTF/wtf/cocoa/NSURLExtras.h
M Source/WTF/wtf/cocoa/NSURLExtras.mm
M Source/WebCore/Modules/applepay/cocoa/PaymentSessionErrorCocoa.mm
M Source/WebCore/Modules/notifications/NotificationOptionsPayloadCocoa.mm
M Source/WebCore/Modules/notifications/NotificationPayloadCocoa.mm
M Source/WebCore/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations
M Source/WebCore/accessibility/mac/AXObjectCacheMac.mm
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
M Source/WebCore/crypto/cocoa/SerializedCryptoKeyWrapMac.mm
M Source/WebCore/editing/cocoa/AttributedString.mm
M Source/WebCore/editing/cocoa/DataDetection.mm
M Source/WebCore/editing/cocoa/HTMLConverter.mm
M Source/WebCore/editing/mac/EditorMac.mm
M Source/WebCore/platform/audio/ios/AudioSessionIOS.mm
M Source/WebCore/platform/cocoa/DragDataCocoa.mm
M Source/WebCore/platform/cocoa/MIMETypeRegistryCocoa.mm
M Source/WebCore/platform/cocoa/PublicSuffixStoreCocoa.mm
M Source/WebCore/platform/cocoa/SerializedPlatformDataCueValue.mm
M
Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm
M
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm
M
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
M Source/WebCore/platform/ios/PasteboardIOS.mm
M Source/WebCore/platform/ios/PlatformPasteboardIOS.mm
M Source/WebCore/platform/ios/PreviewConverterIOS.mm
M Source/WebCore/platform/ios/WebItemProviderPasteboard.mm
M Source/WebCore/platform/mac/PasteboardMac.mm
M Source/WebCore/platform/mac/PasteboardWriter.mm
M Source/WebCore/platform/mac/PlatformPasteboardMac.mm
M Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm
M Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm
M Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm
M Source/WebCore/platform/network/mac/ResourceErrorMac.mm
M
Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm
M Source/WebKit/Scripts/webkit/tests/GeneratedWebKitSecureCoding.cpp
M Source/WebKit/Shared/Cocoa/APIObject.mm
M Source/WebKit/Shared/Cocoa/SandboxInitialiationParametersCocoa.mm
M Source/WebKit/Shared/Cocoa/WKNSString.mm
M Source/WebKit/Shared/JavaScriptEvaluationResult.mm
M Source/WebKit/UIProcess/API/Cocoa/APIAttachmentCocoa.mm
M Source/WebKit/UIProcess/API/Cocoa/WKNavigationResponse.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionCommand.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKNotificationData.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.mm
M Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm
M Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm
M
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionControllerAPITestCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCommandCocoa.mm
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/UIProcess/ios/WKPDFView.mm
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
M
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPICommandsCocoa.mm
M Source/WebKit/webpushd/WebClipCache.mm
M Source/WebKitLegacy/ios/WebView/WebPDFViewIOS.mm
M Source/WebKitLegacy/ios/WebView/WebPDFViewPlaceholder.mm
M Source/WebKitLegacy/mac/Misc/WebNSURLExtras.mm
M Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm
Log Message:
-----------
Reduce use of (NSString *) casting in the codebase
https://bugs.webkit.org/show_bug.cgi?id=291221
Reviewed by Timothy Hatcher.
Use modern casting functions instead for proper casting. For converting from
a WTF::String to a NSString, use `String::createNSString()` instead, which
has the benefit of making it clear it allocates a new NSString and doesn't
return an autoreleased object.
* Source/JavaScriptCore/API/JSValue.mm:
(performPropertyOperation):
(objectToValueWithoutCopy):
(objectToValue):
* Source/WTF/wtf/cocoa/FileSystemCocoa.mm:
(WTF::FileSystemImpl::setExcludedFromBackup):
* Source/WTF/wtf/cocoa/NSURLExtras.h:
* Source/WTF/wtf/cocoa/NSURLExtras.mm:
(WTF::decodeHostName):
(WTF::encodeHostName):
* Source/WebCore/Modules/applepay/cocoa/PaymentSessionErrorCocoa.mm:
(WebCore::additionalError):
* Source/WebCore/Modules/notifications/NotificationOptionsPayloadCocoa.mm:
(WebCore::NotificationOptionsPayload::dictionaryRepresentation const):
* Source/WebCore/Modules/notifications/NotificationPayloadCocoa.mm:
(WebCore::NotificationPayload::dictionaryRepresentation const):
* Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase baseAccessibilitySpeechHint]):
(-[WebAccessibilityObjectWrapperBase baseAccessibilityResolvedEditingStyles]):
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
* Source/WebCore/crypto/cocoa/SerializedCryptoKeyWrapMac.mm:
(WebCore::createAndStoreMasterKey):
* Source/WebCore/editing/cocoa/AttributedString.mm:
(WebCore::toNSObject):
(WebCore::toNSDictionary):
(WebCore::AttributedString::nsAttributedString const):
(WebCore::extractArray):
(WebCore::extractDictionary):
* Source/WebCore/editing/cocoa/DataDetection.mm:
(WebCore::DataDetection::canBePresentedByDataDetectors):
(WebCore::resultIsURL):
* Source/WebCore/editing/cocoa/HTMLConverter.mm:
(HTMLConverter::_processElement):
(fileWrapperForElement):
* Source/WebCore/editing/mac/EditorMac.mm:
(WebCore::Editor::plainTextFromPasteboard):
* Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSessionIOS::updateSpatialExperience):
* Source/WebCore/platform/cocoa/DragDataCocoa.mm:
(WebCore::DragData::asPlainText const):
* Source/WebCore/platform/cocoa/MIMETypeRegistryCocoa.mm:
(WebCore::MIMETypeRegistry::preferredExtensionForMIMEType):
* Source/WebCore/platform/cocoa/PublicSuffixStoreCocoa.mm:
(WebCore::isPublicSuffixCF):
* Source/WebCore/platform/cocoa/SerializedPlatformDataCueValue.mm:
(WebCore::SerializedPlatformDataCueValue::SerializedPlatformDataCueValue):
*
Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::loadSession):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::removeSessionData):
*
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
(WebCore::CDMSessionAVContentKeySession::releaseKeys):
*
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
* Source/WebCore/platform/ios/PasteboardIOS.mm:
(WebCore::cocoaTypeFromHTMLClipboardType):
* Source/WebCore/platform/ios/PlatformPasteboardIOS.mm:
(WebCore::addRepresentationsForPlainText):
(WebCore::PlatformPasteboard::write):
(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):
(WebCore::createItemProviderRegistrationList):
* Source/WebCore/platform/ios/PreviewConverterIOS.mm:
(WebCore::optionsWithPassword):
* Source/WebCore/platform/ios/WebItemProviderPasteboard.mm:
(classForTypeIdentifier):
(-[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:]):
* Source/WebCore/platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::supportedFileUploadPasteboardTypes):
(WebCore::writeURLForTypes):
* Source/WebCore/platform/mac/PasteboardWriter.mm:
(WebCore::createPasteboardWriter):
* Source/WebCore/platform/mac/PlatformPasteboardMac.mm:
(WebCore::isFilePasteboardType):
(WebCore::PlatformPasteboard::getPathnamesForType const):
(WebCore::pasteboardMayContainFilePaths):
(WebCore::PlatformPasteboard::setStringForType):
* Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:
(WebCore::NetworkStorageSession::httpCookiesForURL const):
(WebCore::NetworkStorageSession::setCookiePartition):
(WebCore::NetworkStorageSession::domCookiesForHost):
(WebCore::NetworkStorageSession::startListeningForCookieChangeNotifications):
(WebCore::NetworkStorageSession::stopListeningForCookieChangeNotifications):
* Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
* Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm:
(WebCore::ResourceResponse::initNSURLResponse const):
* Source/WebCore/platform/network/mac/ResourceErrorMac.mm:
(WebCore::createNSErrorFromResourceErrorBase):
*
Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(-[WebCoreResourceHandleAsOperationQueueDelegate connectionDidFinishLoading:]):
* Source/WebKit/Scripts/webkit/tests/GeneratedWebKitSecureCoding.cpp:
(WebKit::vectorFromDictionary):
* Source/WebKit/Shared/Cocoa/APIObject.mm:
(API::Object::toNSObject):
* Source/WebKit/Shared/Cocoa/SandboxInitialiationParametersCocoa.mm:
(WebKit::SandboxInitializationParameters::addPathParameter):
* Source/WebKit/Shared/Cocoa/WKNSString.mm:
* Source/WebKit/Shared/JavaScriptEvaluationResult.mm:
(WebKit::JavaScriptEvaluationResult::toID):
(WebKit::JavaScriptEvaluationResult::toVariant):
* Source/WebKit/UIProcess/API/Cocoa/APIAttachmentCocoa.mm:
(API::Attachment::setFileWrapperAndUpdateContentType):
* Source/WebKit/UIProcess/API/Cocoa/WKNavigationResponse.mm:
(-[WKNavigationResponse _downloadAttribute]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionCommand.mm:
(-[WKWebExtensionCommand debugDescription]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView mediaType]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm:
(-[WKWebView _contentsOfUserInterfaceItem:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(+[WKWebsiteDataStore _removeDataStoreWithIdentifier:completionHandler:]):
(-[WKWebsiteDataStore _getAllBackgroundFetchIdentifiers:]):
* Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.mm:
(nullableNSString):
(-[_WKApplicationManifest rawJSON]):
(-[_WKApplicationManifest name]):
(-[_WKApplicationManifest shortName]):
(-[_WKApplicationManifest applicationDescription]):
* Source/WebKit/UIProcess/API/Cocoa/_WKNotificationData.mm:
(-[_WKNotificationData title]):
(-[_WKNotificationData lang]):
(-[_WKNotificationData body]):
(-[_WKNotificationData tag]):
(-[_WKNotificationData origin]):
(-[_WKNotificationData identifier]):
* Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.mm:
(-[_WKTargetedElementInfo debugDescription]):
* Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm:
(WebKit::SOAuthorizationSession::continueStartAfterDecidePolicy):
* Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm:
(-[WKShareSheet presentWithParameters:inRect:completionHandler:]):
*
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionControllerAPITestCocoa.mm:
(WebKit::WebExtensionController::testResult):
(WebKit::WebExtensionController::testEqual):
(WebKit::WebExtensionController::testLogMessage):
(WebKit::WebExtensionController::testSentMessage):
(WebKit::WebExtensionController::testAdded):
(WebKit::WebExtensionController::testStarted):
(WebKit::WebExtensionController::testFinished):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCommandCocoa.mm:
(WebKit::WebExtensionCommand::setActivationKey):
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView selectedText]):
* Source/WebKit/UIProcess/ios/WKPDFView.mm:
(-[WKPDFView actionSheetAssistant:performAction:]):
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController setLocation:]):
(-[WKFullScreenViewController loadView]):
(-[WKFullScreenViewController _showPhishingAlert]):
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::registerEditCommand):
* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPICommandsCocoa.mm:
(WebKit::WebExtensionContextProxy::dispatchCommandsCommandEvent):
(WebKit::WebExtensionContextProxy::dispatchCommandsChangedEvent):
* Source/WebKit/webpushd/WebClipCache.mm:
(WebPushD::WebClipCache::persist):
* Source/WebKitLegacy/ios/WebView/WebPDFViewIOS.mm:
(-[WebPDFView _checkPDFTitle]):
* Source/WebKitLegacy/ios/WebView/WebPDFViewPlaceholder.mm:
(-[WebPDFViewPlaceholder _updateTitleForDocumentIfAvailable]):
* Source/WebKitLegacy/mac/Misc/WebNSURLExtras.mm:
(-[NSString _web_decodeHostName]):
(-[NSString _web_encodeHostName]):
(-[NSString _webkit_decodeHostName]):
(-[NSString _webkit_encodeHostName]):
* Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
(TestWebKitAPI::TEST(WTF_URLExtras, URLExtras_ParsingError)):
Canonical link: https://commits.webkit.org/293429@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
