Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a6c9e44beeb48680d66936652d86a207f2476e6b
https://github.com/WebKit/WebKit/commit/a6c9e44beeb48680d66936652d86a207f2476e6b
Author: Jean-Yves Avenard <[email protected]>
Date: 2025-04-08 (Tue, 08 Apr 2025)
Changed paths:
M Source/WebKit/Platform/spi/visionos/LinearMediaKit.swiftinterface
M Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaPlayer.swift
M
WebKitLibraries/SDKs/xros2.0-additions.sdk/System/Library/PrivateFrameworks/LinearMediaKit.framework/LinearMediaKit.tbd
M
WebKitLibraries/SDKs/xrsimulator2.0-additions.sdk/System/Library/PrivateFrameworks/LinearMediaKit.framework/LinearMediaKit.tbd
Log Message:
-----------
[visionOS] Don't unnecessarily recreate PlayableViewController if one still
exists
rdar://139181732
https://bugs.webkit.org/show_bug.cgi?id=282525
Reviewed by Andy Estes.
Whenever we exited element fullscreen, VideoPresentationInterface calls
invalidatePlayerViewController which clears its member m_playerViewController.
Immediately after, [WKFullscreenViewController
configureEnvironmentPickerOfFullscreenVideoButtonView] is called which will
have the VideoPresentationInterface
re-create the PlayableViewController. As a one step optimisation, have the
LMK's `makeViewController` store the PlayableViewController created in a weakPtr
and subsequent call return the same value if it still exists.
No change in existing behaviour.
* Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaPlayer.swift:
(SwiftOnlyData.viewController):
(WKSLinearMediaPlayer.makeViewController):
*
WebKitLibraries/SDKs/xros2.0-additions.sdk/System/Library/PrivateFrameworks/LinearMediaKit.framework/LinearMediaKit.tbd:
Adding missing symbols
*
WebKitLibraries/SDKs/xrsimulator2.0-additions.sdk/System/Library/PrivateFrameworks/LinearMediaKit.framework/LinearMediaKit.tbd:
Adding missing symbols
Canonical link: https://commits.webkit.org/293400@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
