Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: aa0b90378a553a179e6d2946aaaa0890ded2c50b
https://github.com/WebKit/WebKit/commit/aa0b90378a553a179e6d2946aaaa0890ded2c50b
Author: Lauro Moura <[email protected]>
Date: 2025-04-08 (Tue, 08 Apr 2025)
Changed paths:
M Source/WebKit/WebProcess/Automation/WebAutomationDOMWindowObserver.cpp
M WebDriverTests/TestExpectations.json
Log Message:
-----------
[WebDriver] Debug assertion in willDestroyGlobalObjectInCachedFrame in both
selenium and W3C back tests
https://bugs.webkit.org/show_bug.cgi?id=283450
Reviewed by BJ Burg.
Upon creation, CachedFrame will detach its Document from the original
LocalFrame, leading to failure in the current assertion in
willDestroyGlobalObjectInCacheFrame.
In the context of WebAutomationSessionProxy, the frame information is
already stored in the observer's callback closure, so we can remove the
frame check in the assertion.
Includes a small drive-by gardening.
* Source/WebKit/WebProcess/Automation/WebAutomationDOMWindowObserver.cpp:
(WebKit::WebAutomationDOMWindowObserver::willDestroyGlobalObjectInCachedFrame):
* WebDriverTests/TestExpectations.json:
Canonical link: https://commits.webkit.org/293431@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
