Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8b8ee0d4b68ff4e5acaa08c41c19461b3395806e
https://github.com/WebKit/WebKit/commit/8b8ee0d4b68ff4e5acaa08c41c19461b3395806e
Author: Ada Chan <[email protected]>
Date: 2025-05-29 (Thu, 29 May 2025)
Changed paths:
M LayoutTests/model-element/model-element-entity-transform-expected.txt
M LayoutTests/model-element/model-element-entity-transform.html
A LayoutTests/model-element/resources/flat-rectangle.usdz
M LayoutTests/model-element/resources/model-element-test-utils.js
M LayoutTests/model-element/resources/model-utils.js
M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm
Log Message:
-----------
Model with zero depth does not scale to fit within the portal
https://bugs.webkit.org/show_bug.cgi?id=293729
rdar://151190516
Reviewed by Mike Wyrzykowski.
The check to see if there are non-empty x and y extents to calculate
the scale ratio with accidentally checks for the z extent as well.
This leads to the scaling logic being skipped if the z extent is zero.
To fix this, the check should only take the x and y extents into account.
* LayoutTests/model-element/model-element-entity-transform-expected.txt:
* LayoutTests/model-element/model-element-entity-transform.html:
* LayoutTests/model-element/resources/flat-rectangle.usdz: Added.
* LayoutTests/model-element/resources/model-element-test-utils.js:
(const.makeSource):
* LayoutTests/model-element/resources/model-utils.js:
(const.assert_3d_matrix_approx_equals):
* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm:
(WebKit::computeScaledExtentsAndCenter):
Canonical link: https://commits.webkit.org/295548@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
