Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 26bb1d983a029efff5614c2f3dbb039c10f861c5
https://github.com/WebKit/WebKit/commit/26bb1d983a029efff5614c2f3dbb039c10f861c5
Author: Antoine Quint <[email protected]>
Date: 2025-05-29 (Thu, 29 May 2025)
Changed paths:
M LayoutTests/TestExpectations
A
LayoutTests/webanimations/asan-crash-under-web-animation-remove-expected.txt
A LayoutTests/webanimations/asan-crash-under-web-animation-remove.html
Log Message:
-----------
[web-animations] `ASAN_TRAP` under `WebAnimation::remove()`
https://bugs.webkit.org/show_bug.cgi?id=289262
rdar://146076422
Reviewed by Cameron McCormack.
We need to use `setTimelineInternal()` in `WebAnimation::remove()` just like we
call
`setEffectInternal()` so that we only reset relationships but don’t run any of
the
Web Animations processing steps when removing the timeline, and thus avoid
resolving
promises.
* LayoutTests/TestExpectations:
* LayoutTests/webanimations/asan-crash-under-web-animation-remove-expected.txt:
Added.
* LayoutTests/webanimations/asan-crash-under-web-animation-remove.html: Added.
* Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::remove):
Originally-landed-as: 289651.246@safari-7621-branch (d3ee8ef6df47).
rdar://151707783
Canonical link: https://commits.webkit.org/295547@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
