Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 76f8911c68827db5f2887a90118aed4e320d75b1
https://github.com/WebKit/WebKit/commit/76f8911c68827db5f2887a90118aed4e320d75b1
Author: Yusuke Suzuki <[email protected]>
Date: 2025-06-06 (Fri, 06 Jun 2025)
Changed paths:
A JSTests/stress/array-join-string-and-int32.js
M Source/JavaScriptCore/runtime/ArrayPrototype.cpp
M Source/JavaScriptCore/runtime/JSStringJoiner.cpp
M Source/JavaScriptCore/runtime/JSStringJoiner.h
Log Message:
-----------
[JSC] Extend JSOnlyStringsJoiner with Int32
https://bugs.webkit.org/show_bug.cgi?id=294089
rdar://152675771
Reviewed by Yijia Huang.
It turned out that this is common that Array includes Strings and Int32s,
and `join` will generate a concatenated string. This patch extends
JSOnlyStringsJoiner to support Int32s. Renaming JSOnlyStringsJoiner to
JSOnlyStringsAndInt32sJoiner, and handling Int32 too.
* JSTests/stress/array-join-string-and-int32.js: Added.
(shouldBe):
* Source/JavaScriptCore/runtime/ArrayPrototype.cpp:
(JSC::fastJoin):
* Source/JavaScriptCore/runtime/JSStringJoiner.cpp:
(JSC::appendStringToData):
(JSC::joinStrings):
(JSC::JSOnlyStringsAndInt32sJoiner::joinImpl):
(JSC::JSOnlyStringsJoiner::joinImpl): Deleted.
* Source/JavaScriptCore/runtime/JSStringJoiner.h:
(JSC::JSOnlyStringsAndInt32sJoiner::JSOnlyStringsAndInt32sJoiner):
(JSC::JSOnlyStringsAndInt32sJoiner::tryJoin):
(JSC::JSOnlyStringsJoiner::JSOnlyStringsJoiner): Deleted.
(JSC::JSOnlyStringsJoiner::tryJoin): Deleted.
Canonical link: https://commits.webkit.org/295918@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
