Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 174717c86b5434d55ecabc5077aa191ef10b4a0d
https://github.com/WebKit/WebKit/commit/174717c86b5434d55ecabc5077aa191ef10b4a0d
Author: Brent Fulgham <[email protected]>
Date: 2025-06-06 (Fri, 06 Jun 2025)
Changed paths:
M Source/WebCore/platform/network/mac/ResourceErrorMac.mm
M Source/WebKit/Shared/Cocoa/WebErrorsCocoa.mm
M Source/WebKitLegacy/mac/Misc/WebKitErrors.m
M Tools/DumpRenderTree/mac/ResourceLoadDelegate.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm
M Tools/TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm
Log Message:
-----------
Replace hard coded @"NSErrorFailingURLKey" in favor of the framework
NSURLErrorFailingURLErrorKey symbol
https://bugs.webkit.org/show_bug.cgi?id=293978
rdar://152520483
Reviewed by Tim Nguyen.
This change replaces some hard-coded string literals with the official
Foundation framework
symbols with the same values. There is no change in behavior.
* Source/WebCore/platform/network/mac/ResourceErrorMac.mm:
(WebCore::createNSErrorFromResourceErrorBase):
(WebCore::ResourceError::platformLazyInit):
(WebCore::ResourceError::hasMatchingFailingURLKeys const):
* Source/WebKit/Shared/Cocoa/WebErrorsCocoa.mm:
(WebKit::createNSError):
* Source/WebKitLegacy/mac/Misc/WebKitErrors.m:
(-[NSError _webkit_initWithDomain:code:URL:]):
(-[NSError
_initWithPluginErrorCode:contentURL:pluginPageURL:pluginName:MIMEType:]):
* Tools/DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[NSError _drt_descriptionSuitableForTestResult]):
(-[ResourceLoadDelegate
webView:resource:didFailLoadingWithError:fromDataSource:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm:
(-[LoadAlternateHTMLStringFromProvisionalLoadErrorController
webView:didFailProvisionalNavigation:withError:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
(-[LoadInvalidURLNavigationActionDelegate
webView:didFailProvisionalNavigation:withError:]):
(TestWebKitAPI::TEST(WebKit, LoadInvalidURLRequestNonASCII)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
(TEST(WKNavigation, HTTPSOnlyWithSameSiteBypass)):
(TEST(WKNavigation, HTTPSOnlyWithHTTPRedirect)):
(TEST(WKNavigation,
PreferredHTTPSPolicyUserMediatedHTTPFallbackWithHTTPRedirect)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
(TEST(SafeBrowsing, WKWebViewGoBackIFrame)):
(TEST(SafeBrowsing, PostResponseIframe)):
* Tools/TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
(-[LoadInvalidURLWebFrameLoadDelegate
webView:didFailProvisionalLoadWithError:forFrame:]):
Canonical link: https://commits.webkit.org/295919@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
