Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0fb43e3086742cde9ab118f669c8c9ba28ee0790
https://github.com/WebKit/WebKit/commit/0fb43e3086742cde9ab118f669c8c9ba28ee0790
Author: Sam Weinig <[email protected]>
Date: 2025-06-17 (Tue, 17 Jun 2025)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-computation.html
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/css/values/color/CSSAbsoluteColor.h
R Source/WebCore/css/values/color/CSSAbsoluteColorSerialization.h
M Source/WebCore/css/values/color/CSSColorLayers.cpp
R Source/WebCore/css/values/color/CSSColorLayersSerialization.h
M Source/WebCore/css/values/color/CSSColorMix.cpp
R Source/WebCore/css/values/color/CSSColorMixSerialization.cpp
R Source/WebCore/css/values/color/CSSColorMixSerialization.h
M Source/WebCore/css/values/color/CSSContrastColor.cpp
R Source/WebCore/css/values/color/CSSContrastColorSerialization.h
M Source/WebCore/css/values/color/CSSRelativeColor.h
R Source/WebCore/css/values/color/CSSRelativeColorSerialization.h
M Source/WebCore/style/StyleCustomProperty.cpp
M Source/WebCore/style/values/color/StyleColor.cpp
M Source/WebCore/style/values/color/StyleColor.h
M Source/WebCore/style/values/color/StyleColorLayers.cpp
M Source/WebCore/style/values/color/StyleColorLayers.h
M Source/WebCore/style/values/color/StyleColorMix.cpp
M Source/WebCore/style/values/color/StyleColorMix.h
M Source/WebCore/style/values/color/StyleContrastColor.cpp
M Source/WebCore/style/values/color/StyleContrastColor.h
M Source/WebCore/style/values/color/StyleCurrentColor.cpp
M Source/WebCore/style/values/color/StyleCurrentColor.h
M Source/WebCore/style/values/color/StyleRelativeColor.h
M Source/WebCore/style/values/color/StyleResolvedColor.cpp
M Source/WebCore/style/values/color/StyleResolvedColor.h
Log Message:
-----------
Update serialization of <color> custom properties to used value
https://bugs.webkit.org/show_bug.cgi?id=294504
Reviewed by Darin Adler and Tim Nguyen.
In https://github.com/w3c/csswg-drafts/issues/10371 it was resolved that:
```
RESOLVED: <color> values returned by getComputedStyle() on standard CSS
properties or registered custom properties is the used value
```
By updating the implementation to match, we are able to remove quite a
lot of extra code in place only to serialize the computed color value,
including removing generic serialization for a few color types.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-computation.html:
- Update test for used value results. Set `color` property so that
currentcolor tests are actually doing something.
* Source/WebCore/style/StyleCustomProperty.cpp:
- Update to go through normal serialization path which takes a RenderStyle
for computing the used color value.
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/values/color/CSSAbsoluteColor.h:
* Source/WebCore/css/values/color/CSSAbsoluteColorSerialization.h: Removed.
* Source/WebCore/css/values/color/CSSColorLayers.cpp:
* Source/WebCore/css/values/color/CSSColorLayersSerialization.h: Removed.
* Source/WebCore/css/values/color/CSSColorMix.cpp:
* Source/WebCore/css/values/color/CSSColorMixSerialization.cpp: Removed.
* Source/WebCore/css/values/color/CSSColorMixSerialization.h: Removed.
* Source/WebCore/css/values/color/CSSContrastColor.cpp:
* Source/WebCore/css/values/color/CSSContrastColorSerialization.h: Removed.
* Source/WebCore/css/values/color/CSSRelativeColor.h:
* Source/WebCore/css/values/color/CSSRelativeColorSerialization.h: Removed.
- Remove now unnecessary generic color type serialization files.
* Source/WebCore/style/values/color/StyleColor.cpp:
* Source/WebCore/style/values/color/StyleColor.h:
* Source/WebCore/style/values/color/StyleColorLayers.cpp:
* Source/WebCore/style/values/color/StyleColorLayers.h:
* Source/WebCore/style/values/color/StyleColorMix.cpp:
* Source/WebCore/style/values/color/StyleColorMix.h:
* Source/WebCore/style/values/color/StyleContrastColor.cpp:
* Source/WebCore/style/values/color/StyleContrastColor.h:
* Source/WebCore/style/values/color/StyleCurrentColor.cpp:
* Source/WebCore/style/values/color/StyleCurrentColor.h:
* Source/WebCore/style/values/color/StyleRelativeColor.h:
* Source/WebCore/style/values/color/StyleResolvedColor.cpp:
* Source/WebCore/style/values/color/StyleResolvedColor.h:
- Remove serializationForCSS() overload that does not take a RenderStyle.
- In a few places, updates the TextStream overloads to contain simplified
serialization that used to just call serializationForCSS().
Canonical link: https://commits.webkit.org/296337@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
