Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bbf50b748dba84f51f7002498e72f8db18bc1f6c
https://github.com/WebKit/WebKit/commit/bbf50b748dba84f51f7002498e72f8db18bc1f6c
Author: Arvind Kutirakulam <[email protected]>
Date: 2025-06-17 (Tue, 17 Jun 2025)
Changed paths:
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources-output.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/Shared/Extensions/WebExtensionPermission.cpp
M Source/WebKit/Shared/Extensions/WebExtensionPermission.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionPermission.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionPermissionPrivate.h
M Source/WebKit/UIProcess/Extensions/WebExtension.cpp
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPINamespaceCocoa.mm
A Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIBookmarks.h
M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPINamespace.h
A
Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPIBookmarks.idl
M
Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPINamespace.idl
M Tools/TestWebKitAPI/SourcesCocoa.txt
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
A Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIBookmarks.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPISidebar.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm
Log Message:
-----------
Add Bookmarks API to the browser namespace
rdar://152868076
https://bugs.webkit.org/show_bug.cgi?id=294224
Reviewed by Brian Weinstein and Timothy Hatcher.
Add Bookmarks API to the browser namespace. Files included to check for bookmark
permissions in the manifests and have test files.
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources-output.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Shared/Extensions/WebExtensionPermission.cpp:
(WebKit::WebExtensionPermission::bookmarks):
* Source/WebKit/Shared/Extensions/WebExtensionPermission.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionPermission.mm: Gives access to
Bookmark API if bookmarks are enabled in the mm file
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionPermissionPrivate.h:
* Source/WebKit/UIProcess/Extensions/WebExtension.cpp:
(WebKit::WebExtension::supportedPermissions):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
*
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPINamespaceCocoa.mm:
(WebKit::WebExtensionAPINamespace::isPropertyAllowed): Checks for bookmarks in
the manifest
(WebKit::WebExtensionAPINamespace::bookmarks):
* Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIBookmarks.h: Copied
from Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionPermissionPrivate.h.
* Source/WebKit/WebProcess/Extensions/API/WebExtensionAPINamespace.h:
* Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPIBookmarks.idl:
Copied from Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionPermissionPrivate.h.
* Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPINamespace.idl:
* Tools/TestWebKitAPI/SourcesCocoa.txt:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIBookmarks.mm: Added.
(TestWebKitAPI::WKWebExtensionAPIBookmarks::WKWebExtensionAPIBookmarks):
(TestWebKitAPI::WKWebExtensionAPIBookmarks::getManagerFor):
(TestWebKitAPI::TEST_F(WKWebExtensionAPIBookmarks,
APISUnavailableWhenManifestDoesNotRequest)):
Tests when the manifest does not includes the bookmarks permissions
(TestWebKitAPI::TEST_F(WKWebExtensionAPIBookmarks,
APIAvailableWhenManifestRequests)): Tests when the manifest includes the
bookmarks permissions
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPISidebar.mm:
(TestWebKitAPI::WKWebExtensionAPISidebar::WKWebExtensionAPISidebar):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm: Included
import to fix building issues
Canonical link: https://commits.webkit.org/296338@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
