Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7c3bccb28c9d00d450851dd40dcc5a3e4554f8ce
      
https://github.com/WebKit/WebKit/commit/7c3bccb28c9d00d450851dd40dcc5a3e4554f8ce
  Author: Arvind Kutirakulam <[email protected]>
  Date:   2025-06-30 (Mon, 30 Jun 2025)

  Changed paths:
    M 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIBookmarksCocoa.mm
    M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIBookmarks.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIBookmarks.mm

  Log Message:
  -----------
  Web Extensions: Parsing for Create() Bookmark function
rdar://154231013
https://bugs.webkit.org/show_bug.cgi?id=294932

Reviewed by Timothy Hatcher.

Parses the create function using a CreateDetails Object which takes in the 
parameters
for the dictionary. For now this info from the dictionary is put into 
MockBookmarkNodes.
Also makes sure default type of a bookmark create request is assigned properly 
and
dateAdded is a parameter you can set only for testing purposes.
Created tests for these as well.

* 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIBookmarksCocoa.mm:
(WebKit::toWebAPI):
(WebKit::toTypeImpl):
(WebKit::WebExtensionAPIBookmarks::createBookmark):
(WebKit::WebExtensionAPIBookmarks::getRecent):
(WebKit::WebExtensionAPIBookmarks::createDictionaryFromNode):
* Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIBookmarks.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIBookmarks.mm:
(TestWebKitAPI::TEST_F(WKWebExtensionAPIBookmarks, BookmarksAPICreateParse)):

Canonical link: https://commits.webkit.org/296824@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to