Diff
Modified: trunk/LayoutTests/ChangeLog (112984 => 112985)
--- trunk/LayoutTests/ChangeLog 2012-04-03 04:24:37 UTC (rev 112984)
+++ trunk/LayoutTests/ChangeLog 2012-04-03 05:05:42 UTC (rev 112985)
@@ -1,3 +1,14 @@
+2012-04-02 Alexander Shalamov <[email protected]>
+
+ [EFL] LayoutTestController needs implementation of isPageBoxVisible
+ https://bugs.webkit.org/show_bug.cgi?id=82591
+
+ Unskip printing/page-format-data.html
+
+ Reviewed by Hajime Morita.
+
+ * platform/efl/Skipped:
+
2012-04-02 Raphael Kubo da Costa <[email protected]>
[EFL] Gardening; update expectations in fast/dom.
Modified: trunk/LayoutTests/platform/efl/Skipped (112984 => 112985)
--- trunk/LayoutTests/platform/efl/Skipped 2012-04-03 04:24:37 UTC (rev 112984)
+++ trunk/LayoutTests/platform/efl/Skipped 2012-04-03 05:05:42 UTC (rev 112985)
@@ -399,12 +399,6 @@
# EFL's LayoutTestController does not implement pageProperty
printing/page-rule-selection.html
-# EFL's LayoutTestController does not implement pageProperty
-printing/page-format-data.html
-
-# EFL's LayoutTestController does not implement pageSizeAndMarginsInPixels
-printing/page-format-data.html
-
# EFL's LayoutTestController does not implement setCustomPolicyDelegate
fast/loader/_javascript_-url-hierarchical-execution.html
fast/loader/onload-policy-ignore-for-frame.html
Modified: trunk/Source/WebKit/efl/ChangeLog (112984 => 112985)
--- trunk/Source/WebKit/efl/ChangeLog 2012-04-03 04:24:37 UTC (rev 112984)
+++ trunk/Source/WebKit/efl/ChangeLog 2012-04-03 05:05:42 UTC (rev 112985)
@@ -1,3 +1,17 @@
+2012-04-02 Alexander Shalamov <[email protected]>
+
+ [EFL] LayoutTestController needs implementation of isPageBoxVisible
+ https://bugs.webkit.org/show_bug.cgi?id=82591
+
+ Add missing implementation for isPageBoxVisible to EFL's
+ DumpRenderTreeSupport.
+
+ Reviewed by Hajime Morita.
+
+ * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
+ (DumpRenderTreeSupportEfl::isPageBoxVisible):
+ * WebCoreSupport/DumpRenderTreeSupportEfl.h:
+
2012-04-01 Gyuyoung Kim <[email protected]>
Support the Network Information API
Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp (112984 => 112985)
--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp 2012-04-03 04:24:37 UTC (rev 112984)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp 2012-04-03 05:05:42 UTC (rev 112985)
@@ -119,6 +119,21 @@
return frame->tree()->parent();
}
+bool DumpRenderTreeSupportEfl::isPageBoxVisible(const Evas_Object* ewkFrame, int pageIndex)
+{
+ const WebCore::Frame* frame = EWKPrivate::coreFrame(ewkFrame);
+
+ if (!frame)
+ return false;
+
+ WebCore::Document* document = frame->document();
+
+ if (!document)
+ return false;
+
+ return document->isPageBoxVisible(pageIndex);
+}
+
void DumpRenderTreeSupportEfl::layoutFrame(Evas_Object* ewkFrame)
{
WebCore::Frame* frame = EWKPrivate::coreFrame(ewkFrame);
Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h (112984 => 112985)
--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h 2012-04-03 04:24:37 UTC (rev 112984)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h 2012-04-03 05:05:42 UTC (rev 112985)
@@ -50,6 +50,7 @@
static String counterValueByElementId(const Evas_Object* ewkFrame, const char* elementId);
static Eina_List* frameChildren(const Evas_Object* ewkFrame);
static WebCore::Frame* frameParent(const Evas_Object* ewkFrame);
+ static bool isPageBoxVisible(const Evas_Object* ewkFrame, int pageIndex);
static void layoutFrame(Evas_Object* ewkFrame);
static int numberOfPages(const Evas_Object* ewkFrame, float pageWidth, float pageHeight);
static int numberOfPagesForElementId(const Evas_Object* ewkFrame, const char* elementId, float pageWidth, float pageHeight);
Modified: trunk/Tools/ChangeLog (112984 => 112985)
--- trunk/Tools/ChangeLog 2012-04-03 04:24:37 UTC (rev 112984)
+++ trunk/Tools/ChangeLog 2012-04-03 05:05:42 UTC (rev 112985)
@@ -1,3 +1,16 @@
+2012-04-02 Alexander Shalamov <[email protected]>
+
+ [EFL] LayoutTestController needs implementation of isPageBoxVisible
+ https://bugs.webkit.org/show_bug.cgi?id=82591
+
+ Add missing implementation to isPageBoxVisible to EFL's LayoutTestController
+ in order to unskip printing/page-format-data.html
+
+ Reviewed by Hajime Morita.
+
+ * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+ (LayoutTestController::isPageBoxVisible):
+
2012-04-02 Simon Fraser <[email protected]>
run-webkit-tests with a relative --root causes tests to fail because DYLD_LIBRARY_PATH is not set
Modified: trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp (112984 => 112985)
--- trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp 2012-04-03 04:24:37 UTC (rev 112984)
+++ trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp 2012-04-03 05:05:42 UTC (rev 112985)
@@ -139,10 +139,9 @@
return 0;
}
-bool LayoutTestController::isPageBoxVisible(int) const
+bool LayoutTestController::isPageBoxVisible(int pageIndex) const
{
- notImplemented();
- return false;
+ return DumpRenderTreeSupportEfl::isPageBoxVisible(browser->mainFrame(), pageIndex);
}
JSRetainPtr<JSStringRef> LayoutTestController::pageSizeAndMarginsInPixels(int, int, int, int, int, int, int) const
