Title: [112986] trunk
Revision
112986
Author
[email protected]
Date
2012-04-02 22:10:59 -0700 (Mon, 02 Apr 2012)

Log Message

EFL's LayoutTestController disableImageLoading implementation.
https://bugs.webkit.org/show_bug.cgi?id=82848

Patch by Mikhail Pozdnyakov <[email protected]> on 2012-04-02
Reviewed by Hajime Morita.

Tools:

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::disableImageLoading):

LayoutTests:

* platform/efl/Skipped:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (112985 => 112986)


--- trunk/LayoutTests/ChangeLog	2012-04-03 05:05:42 UTC (rev 112985)
+++ trunk/LayoutTests/ChangeLog	2012-04-03 05:10:59 UTC (rev 112986)
@@ -1,3 +1,12 @@
+2012-04-02  Mikhail Pozdnyakov  <[email protected]>
+
+        EFL's LayoutTestController disableImageLoading implementation.
+        https://bugs.webkit.org/show_bug.cgi?id=82848
+
+        Reviewed by Hajime Morita.
+
+        * platform/efl/Skipped:
+
 2012-04-02  Alexander Shalamov  <[email protected]>
 
         [EFL] LayoutTestController needs implementation of isPageBoxVisible

Modified: trunk/LayoutTests/platform/efl/Skipped (112985 => 112986)


--- trunk/LayoutTests/platform/efl/Skipped	2012-04-03 05:05:42 UTC (rev 112985)
+++ trunk/LayoutTests/platform/efl/Skipped	2012-04-03 05:10:59 UTC (rev 112986)
@@ -458,10 +458,6 @@
 # EFL's LayoutTestController does not implement setAuthorAndUserStylesEnabled
 fast/css/disabled-author-styles.html
 
-# EFL's LayoutTestController does not implement disableImageLoading
-http/tests/misc/favicon-loads-with-icon-loading-override.html
-http/tests/misc/favicon-loads-with-images-disabled.html
-
 # EFL's LayoutTestController does not implement setJavaScriptProfilingEnabled
 fast/profiler
 

Modified: trunk/Tools/ChangeLog (112985 => 112986)


--- trunk/Tools/ChangeLog	2012-04-03 05:05:42 UTC (rev 112985)
+++ trunk/Tools/ChangeLog	2012-04-03 05:10:59 UTC (rev 112986)
@@ -1,3 +1,15 @@
+2012-04-02  Mikhail Pozdnyakov  <[email protected]>
+
+        EFL's LayoutTestController disableImageLoading implementation.
+        https://bugs.webkit.org/show_bug.cgi?id=82848
+
+        Reviewed by Hajime Morita.
+
+        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
+        (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
+        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+        (LayoutTestController::disableImageLoading):
+
 2012-04-02  Alexander Shalamov  <[email protected]>
 
         [EFL] LayoutTestController needs implementation of isPageBoxVisible

Modified: trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp (112985 => 112986)


--- trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp	2012-04-03 05:05:42 UTC (rev 112985)
+++ trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp	2012-04-03 05:10:59 UTC (rev 112986)
@@ -175,6 +175,7 @@
     ewk_view_setting_enable_plugins_set(mainView(), EINA_TRUE);
     ewk_view_setting_scripts_can_open_windows_set(mainView(), EINA_TRUE);
     ewk_view_setting_scripts_can_close_windows_set(mainView(), EINA_TRUE);
+    ewk_view_setting_auto_load_images_set(mainView(), EINA_TRUE);
 
     ewk_view_zoom_set(mainView(), 1.0, 0, 0);
     ewk_view_scale_set(mainView(), 1.0, 0, 0);

Modified: trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp (112985 => 112986)


--- trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp	2012-04-03 05:05:42 UTC (rev 112985)
+++ trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp	2012-04-03 05:10:59 UTC (rev 112986)
@@ -358,9 +358,7 @@
 
 void LayoutTestController::disableImageLoading()
 {
-    // FIXME: Implement for testing fix for https://bugs.webkit.org/show_bug.cgi?id=27896
-    // Also need to make sure image loading is re-enabled for each new test.
-    notImplemented();
+    ewk_view_setting_auto_load_images_set(browser->mainView(), EINA_FALSE);
 }
 
 void LayoutTestController::setMockDeviceOrientation(bool, double, bool, double, bool, double)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to