Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1a86d2229137761f806d0068a8e38dced3a318c1
https://github.com/WebKit/WebKit/commit/1a86d2229137761f806d0068a8e38dced3a318c1
Author: Wenson Hsieh <[email protected]>
Date: 2025-09-23 (Tue, 23 Sep 2025)
Changed paths:
M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SmartLists.mm
Log Message:
-----------
REGRESSION (299884@main): [macOS] Safari AutoFill filling unit tests are
hanging
https://bugs.webkit.org/show_bug.cgi?id=299379
rdar://160980482
Reviewed by Richard Robinson and Abrar Rahman Protyasha.
Partially revert logic introduced in 299884@main, which observes changes to all
user defaults in
order to update smart lists enablement. This was only necessary for the
scenario where the user
default is modified by the user or app, through the command line or
`NSUserDefaults` API.
Importantly, these user defaults still persist across app launches, and also
update correctly as
the user uses the context menu or other UI that's integrated with `-[WKWebView
_toggleSmartLists:]`.
Test: Tools/TestWebKitAPI/Tests/WebKitCocoa/SmartLists.mm
* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::registerNotificationObservers):
(WebKit::WebProcessPool::unregisterNotificationObservers):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SmartLists.mm:
(TEST(SmartLists,
EnablementIsLogicallyConsistentWhenInterfacedThroughResponder)):
Adjust an API test by moving the `user default => nil, preference => true` test
case up to the
start, when the user default is (initially) set to `nil`.
Canonical link: https://commits.webkit.org/300414@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
