Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0d9b3a0d2ce0834de493974c9e5cffd394bcdc10
      
https://github.com/WebKit/WebKit/commit/0d9b3a0d2ce0834de493974c9e5cffd394bcdc10
  Author: Richard Robinson <[email protected]>
  Date:   2025-09-30 (Tue, 30 Sep 2025)

  Changed paths:
    M Source/JavaScriptCore/API/JSContextInternal.h
    M Source/JavaScriptCore/API/JSContextPrivate.h
    M Source/JavaScriptCore/API/JSScript.h
    M Source/JavaScriptCore/API/JSValueInternal.h
    M Source/JavaScriptCore/API/JSValuePrivate.h
    M Source/JavaScriptCore/API/JSVirtualMachinePrivate.h
    M Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig
    M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
    A Source/JavaScriptCore/JavaScriptCore_Private.modulemap
    M Source/JavaScriptCore/config.h
    M Source/JavaScriptCore/wasm/WasmContext.h
    M Source/JavaScriptCore/wasm/WasmNameSection.h

  Log Message:
  -----------
  [Swift in WebKit] Add a modulemap for the private interface of JSC
https://bugs.webkit.org/show_bug.cgi?id=298124
rdar://159472949

Reviewed by Keith Miller.

Add a private module map to JSC, a prerequisite for modularizing WebCore.

* Source/JavaScriptCore/API/JSContextInternal.h:
* Source/JavaScriptCore/API/JSContextPrivate.h:
* Source/JavaScriptCore/API/JSScript.h:
* Source/JavaScriptCore/API/JSValueInternal.h:
* Source/JavaScriptCore/API/JSValuePrivate.h:
* Source/JavaScriptCore/API/JSVirtualMachinePrivate.h:

Add some missing OBJC guards, so that JSC can be compiled in C++ only mode.

* Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:

- Ensure the module verifier runs on the public SDK to make it easier to catch 
issues
- Adjust the module verification flags to use the built WTF/bmalloc modules 
instead of the system ones
- Disable verification for Obj-C and C. This is done because the JSC private 
interface would require
the addition of __cplusplus guards to every private header file. This itself 
wouldn't be needed usually,
however the module verifier does not support module require clauses; if this 
functionality becomes supported,
or if a custom verifier is written, these languages can be re-added. It is 
reasonably safe to omit this
subset of languages since ObjC++ and C++ are still covered, and it is unlikely 
for C++ API to accidentally
be added to the public JSC API.

* Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
* Source/JavaScriptCore/JavaScriptCore_Private.modulemap: Added.

Canonical link: https://commits.webkit.org/300796@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to