Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 115e0938e581f72db955bb1326f39d4003ba2f6a
https://github.com/WebKit/WebKit/commit/115e0938e581f72db955bb1326f39d4003ba2f6a
Author: Wenson Hsieh <[email protected]>
Date: 2025-10-23 (Thu, 23 Oct 2025)
Changed paths:
M Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm
M Tools/TestWebKitAPI/mac/NSFontPanelTesting.h
M Tools/TestWebKitAPI/mac/NSFontPanelTesting.mm
Log Message:
-----------
[ Tahoe ] TestWebKitAPI.FontAttributes.FontAttributesAfterChangingSelection
is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=301207
rdar://163133384
Reviewed by Aditya Keerthi.
With changes in macOS 26, `NSFontManager`, `NSFontPanel` and `NSFontEffectsBox`
no longer contain
a handful of toolbar items that this test relied on, in order to inspect text
shadow, underline,
and strikethrough styles for the current selection. To mitigate this, we
refactor our test
infrastructure to directly inspect the `_selection` ivar in `NSFontPanel`.
* Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
(TestWebKitAPI::TEST(FontAttributes, FontAttributesAfterChangingSelection)):
* Tools/TestWebKitAPI/mac/NSFontPanelTesting.h:
* Tools/TestWebKitAPI/mac/NSFontPanelTesting.mm:
(-[NSFontPanel _selectionAttributeValue:]):
(-[NSFontPanel lastTextShadow]):
Replace helpers that currently return the state of text shadow editing UI with
a helper that just
returns the font manager's last known `NSShadow` at the current selection.
(-[NSFontPanel hasUnderline]):
(-[NSFontPanel hasStrikeThrough]):
(findSubviewOfClass): Deleted.
(-[NSFontPanel underlineToolbarButton]): Deleted.
(-[NSFontPanel strikeThroughToolbarButton]): Deleted.
(-[NSFontPanel shadowBlurSlider]): Deleted.
(-[NSFontPanel shadowOpacitySlider]): Deleted.
(-[NSFontPanel shadowLengthSlider]): Deleted.
(-[NSFontPanel shadowToggleButton]): Deleted.
(-[NSFontPanel hasShadow]): Deleted.
(-[NSFontPanel shadowLength]): Deleted.
(-[NSFontPanel setShadowLength:]): Deleted.
(-[NSFontPanel shadowOpacity]): Deleted.
(-[NSFontPanel setShadowOpacity:]): Deleted.
(-[NSFontPanel shadowBlur]): Deleted.
(-[NSFontPanel setShadowBlur:]): Deleted.
Canonical link: https://commits.webkit.org/302048@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
