Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 114e809bdd0e97118a0efd2a24f9f727aff5f8bc
https://github.com/WebKit/WebKit/commit/114e809bdd0e97118a0efd2a24f9f727aff5f8bc
Author: Wenson Hsieh <[email protected]>
Date: 2025-10-23 (Thu, 23 Oct 2025)
Changed paths:
M Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h
M Tools/TestWebKitAPI/Tests/mac/FontManagerTests.mm
M Tools/TestWebKitAPI/mac/NSFontPanelTesting.h
M Tools/TestWebKitAPI/mac/NSFontPanelTesting.mm
Log Message:
-----------
[macOS 26] TestWebKitAPI.FontManagerTests.ChangeAttributesWithFontEffectsBox
fails due to changes in NSFontPanel
https://bugs.webkit.org/show_bug.cgi?id=301352
rdar://163133860
Reviewed by Aditya Keerthi.
Since macOS 26, parts of the `NSFontPanel` UI have been reimplemented in Swift,
or otherwise changed
so that styling options are now behind popovers and menus. As a result, all of
the popup buttons
previously found by looking for `NSFontPanel*ToolbarItem` no longer exist.
This test currently tries (and fails) to interact with these nonexistent
controls. Fix this by
changing how these tests work, such that they directly change the
`_attributesToAdd` and
`_attributesToRemove` ivars that determine which text styles should be applied
when calling into
`-changeAttributes:`.
* Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
* Tools/TestWebKitAPI/Tests/mac/FontManagerTests.mm:
(TestWebKitAPI::TEST(FontManagerTests, ChangeAttributesWithFontEffectsBox)):
* Tools/TestWebKitAPI/mac/NSFontPanelTesting.h:
* Tools/TestWebKitAPI/mac/NSFontPanelTesting.mm:
(-[NSBox _addAttribute:value:]):
(-[NSBox _removeAttribute:]):
(-[NSBox _clearAttributes]):
Add helpers to directly add or remove text styling attributes.
(-[NSFontPanel fontEffectsBox]):
(-[NSFontPanel setUnderlineStyle:]):
(-[NSFontPanel setStrikethroughStyle:]):
(-[NSFontPanel setTextShadow:]):
(-[NSFontPanel commitAttributeChanges]):
(findMenuItemWithTitle): Deleted.
(-[NSFontPanel chooseUnderlineMenuItemWithTitle:]): Deleted.
(-[NSFontPanel chooseStrikeThroughMenuItemWithTitle:]): Deleted.
(-[NSFontPanel toggleShadow]): Deleted.
Canonical link: https://commits.webkit.org/302033@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
